Skip to content

Commit

Permalink
Fix google authentication (#217)
Browse files Browse the repository at this point in the history
* [KFI]fix(client-auth-google): Add allow-scripts true to the iframe

* [KFI]fix(client-auth-google): Add allow-scripts attribute

* Fix sandbox attr's value
  • Loading branch information
herflis committed May 23, 2019
1 parent ac7b698 commit 457224e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/sn-client-auth-google/src/GoogleOauthProvider.ts
Expand Up @@ -112,8 +112,7 @@ export class GoogleOauthProvider implements OauthProvider {
const token = await new Promise<string>((resolve, reject) => {
this.iframe = this.windowInstance.document.createElement('iframe')
this.iframe.style.display = 'none'
this.iframe.setAttribute('sandbox', 'allow-same-origin')
this.iframe.setAttribute('sandbox', 'allow-scripts')
this.iframe.setAttribute('sandbox', 'allow-same-origin allow-scripts')

this.iframe.onload = async ev => {
let location: Location | null = null
Expand Down

0 comments on commit 457224e

Please sign in to comment.