Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading (system) files #29

Open
2 tasks
kultsar opened this issue Dec 11, 2018 · 2 comments
Open
2 tasks

Downloading (system) files #29

kultsar opened this issue Dec 11, 2018 · 2 comments

Comments

@kultsar
Copy link
Contributor

kultsar commented Dec 11, 2018

@herflis commented on Thu Aug 02 2018

Some of the file types cannot be downloaded from the repository (.json, .txt, .md, etc). Some of them are system files, other ones have an extension that is not listen in the web.config. The question is what should happen if a file cannot be downloaded by the user because its type? The possible answers:

  • 'Download' should not be listed in the actionmenu, if the file cannot be downloaded
  • Add all this extensions to the web.config so that all the file types can have the same handler and could be downloaded

See current handler+extension definitions here:
https://github.com/SenseNet/sensenet/blob/master/src/nuget/content/Web.config.transform

@kultsar kultsar changed the title [DMS] Downloading (system) files [dms-demo] Downloading (system) files Dec 11, 2018
@kultsar kultsar self-assigned this Dec 11, 2018
gallayl added a commit that referenced this issue Jan 9, 2019
* [KFI]chore(package): updated Typescript to latest and fixed type definitions

* [KFI]feat(Upload): added support for observing upload progress info

* [KFI]fix(Upload): fixed uploadFromFileList folder structuring

* [KFI]chore(package): added uuid, @types/uuid

* [KFI]refactor(Upload): progress on upload tracking

* [KFI]chore(package): updated dependencies

* [KFI]test(Upload): added tests for uploading from fileList and progress tracking
gallayl pushed a commit that referenced this issue Jan 9, 2019
* Merge master into develop branch (#35)

* Feature/basic pages and layout (#8)

* chore(dependencies): Update dependencies

* chore(package): removed sn-client-cli from dependencies

* feat: Add basic layout and routes

Basic routes are added for login, registration and the dashboard. For choosing between login and
registration a tabstrip is added. If theres no authenticated user, she will be redirected to the
login page

* test: Fix test imports

* fix: Add missing dependency

* chore: Fix dependencies

* Merge features/dms login (#10)

* chore(dependencies): Update dependencies

* chore(package): removed sn-client-cli from dependencies

* feat: Add basic layout and routes

Basic routes are added for login, registration and the dashboard. For choosing between login and
registration a tabstrip is added. If theres no authenticated user, she will be redirected to the
login page

* test: Fix test imports

* fix: Add missing dependency

* chore: Fix dependencies

* feat(Login): Add login form

* chore: Remove package-lock.json

* chore: Add package-lock.json to the .gitignore

* test: Fix tests

* Feature/repository url (#12)

* build(repository URL): Resolve URL from REACT_APP_SERVICE_URL environment variable

* refactor(create-react-app, repository): Ejected create-react-app, removed uglify from build, added f

* fix(package): changed tsConfigFile from absolute URL to relative

* fix(package): fixed json syntax

---------

Ejected create-react-app in order to customize build script
Removed UglifyJs from build script
RepositoryUrl will be resolved from REACT_APP_SERVICE_URL environment variable, falls back to https://sn-local/

* Features/dms registration (#14)

* feat(Add registration form):

* feat: Add registration related string resources

* fix(Login): Fix login button onclick

* feat: Email validation on client-side and format hint in the placeholder

* feat(Registration): Add password format check

Password needs to be longer than 8 characters, needs to contain numbers, capitals and special
characters

* feat(Registration): Add password confirmation

* fix(Registration): Improve password validation

* feat(Registration): Improve registration process

Registration Actions, Epic and Reducers are added

* chore(privacypolicy): Add cookieconsent

Add cookieconsent to inform users about our privacy policy. Keep in mind, that the url of the
privacy policy content should be changed after we have one for the mvps

* feat(Registration): Add recaptcha

* docs(Readme): Add a short info about the enviroment variables

* fix(package): update css-loader to version 0.28.6 (#22)

* fix(package): update css-loader to version 0.28.7 (#23)

* [KFI]DMS MVP User dashboard (#24)

* [KFI]chore(commitizen): Change cz-changelog to a sensenet KFI specific one

* [KFI]feat(Dashboard): Add app header

App header with basic stuff like quicksearch, loggedin users data, logo, menu, etc.

* [KFI]feat(Dashboard): Add static floating action button

* [KFI]feat(HeaderLogo): Add a white sn logo

* [KFI]feat(UserPanel): Add avatar of the current user

* [KFI]fix: Fix dependencies

* [KFI]fix: Fix dependencies

* [KFI]fix: Fix material-ui version

* [KFI]fix(Routing): Change BrowserRouter to HashRouter

* [KFI]fix(Routes): Fix routes

* fix(package): update typescript to version 2.5.2 (#25)

* fix(package): update react-error-overlay to version 2.0.1 (#27)

* fix(package): update react-dev-utils to version 4.0.1 (#28)

* fix(package): update jest to version 21.0.0 (#29)

* fix(package): update ts-jest to version 21.0.0 (#30)

* fix(package): update autoprefixer to version 7.1.4 (#32)

* Fix/reg and login (#33)

* [KFI]chore: Remove redux-loggers typing file as a dependency

* [KFI]feat(registration): Reduce password strength

Password should be now at least three character long

* [KFI]fix(registration): Fix redirect after registration

* Feature/logout (#34)

* [KFI]feat(Logout): Add user logout functionality

* [KFI]refactor(Actions): Shorten actionnames to login and registration

* sn-client-js update (#114)

* [KFI]fix(project): sn-client-js dependencies

* [KFI]chore(package): updated sn-client-js to 3.0.0-development.2

* [KFI]fix(ReCaptcha): Fix recaptcha

* Merge feat/upload to develop (#121)

* [KFI]fix(Authentication): Fix loginstate by the new enum format of authentication.loginstate

* [KFI]test: Fix tests based on the changes in sn-client-js

* [KFI]refactor(Selection): Change selection related stuff based on the changes in sn-redux

* [KFI]feat(Actions): Add delete batch functionality to the actionlist

* [KFI]feat(BatchActions): Bind delete- copy- and movebatch actions to the appropriate key and dragand

* [KFI]fix(Registration): Fix logo size on registration interface

* [KFI]feat(Upload): Add upload functionality to the main actionmenu

* [KFI]feat(GoogleAuth): Add basic google auth stuff

* [KFI]feat(FontIcons): Add fontawesome component plus related font and css files

* [KFI]feat(GoogleAuth): Add 'Sign in with Google' button with its three states

* [KFI]feat(GoogleAuth): Add 'Sign in with Google' button to the login and registration surface

* [KFI]fix: Fix update related stuff

* [KFI]fix: Fix upload and actions
@herflis herflis changed the title [dms-demo] Downloading (system) files Downloading (system) files Jun 6, 2019
@herflis herflis added hacktoberfest Newcomers welcome! and removed discussion labels Oct 1, 2019
@sumitkharche
Copy link

@herflis Is this issue resolved?

@enikonemeth
Copy link
Contributor

@kultsar : Are you still working on this issue?

@herflis herflis removed the hacktoberfest Newcomers welcome! label Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants