New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #70

Open
kultsar opened this Issue Oct 5, 2018 · 0 comments

Comments

2 participants
@kultsar
Copy link
Contributor

kultsar commented Oct 5, 2018

  • create tasks

Info from backend

  • If file contents change that may affect page number and/or position. Do we remove ALL shapes (including comments)? --> Yes
  • What can we do with Office 365? Can we do preview in read only mode, comments? SenseNet/sn-dms-demo#70
    • We can preview in read only, but only off365 files
    • We can comment, but only off365 files. No other shapes

General

  • One comment - one page
  • Can scroll comments within page if comments do not fit page height - Note: Rethink UX for inline scrolling. Eg. touch screen users can get trapped (https://baymard.com/blog/inline-scroll-areas etc.)
  • Longer contents will be truncated. Show more/show less links will extend/collapse full content.
  • Behavior for comment positions and comments
    • comment positions will be marked with a number in a circle positioned by user anywhere over the page
    • when mouse hovers over a comment, its number should be emphasized/highlighted somehow
    • DISCUSS: How to make sure numbers will not blank content underneeth...? Default colour/highlight should be weak, perhaps...?

Reply

  • replies can be added, indented perhaps, but one level only
  • DISCUSS: allow adding replies to replies at the same level?

Permissions

  • see
  • write (=create/edit/reply) - (DISCUSS: write your own comments only? - add edit all comments permission?)
  • remove your own comment. DISCUSS: what if there are replies?
    • a: remove comment and all replies, or
    • b: remove comment contents, but leave a stub and leave replies listed under it

Moving comment (modifying position)

  • only the owner, with drag-and-drop

Store

  • file - which file the comment belongs to
  • who - who commented
  • when - DISCUSS: allow for comment modification? Store creation and modification dates?
  • Contents - DISCUSS: simple text?
  • Page number
  • Position
  • Order: height, width

Backend

  • Add as a separate contents in folder created under the commented file, and use sensenet's permission system

Implementation plan

  • New Comment CTD. Place where the preview content is located, under the file in services.
  • Create a folder for holding comments under File's content template
  • Patch: create the comments folder under all(!) files with correct permissions
  • Create components in sn-document-viewer-react
  • Use these components in DMS demo

@herflis herflis transferred this issue from SenseNet/sn-document-viewer-react Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment