Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in DocViewer #70

Closed
kultsar opened this issue Oct 5, 2018 · 0 comments
Closed

Comments in DocViewer #70

kultsar opened this issue Oct 5, 2018 · 0 comments
Assignees
Labels
DMS Issues related to the sn-dms-demo document-viewer-react Epic
Milestone

Comments

@kultsar
Copy link
Contributor

kultsar commented Oct 5, 2018

Permissions

  • See comments: open permission on content
  • Add comments: open permission on content
  • Modify comments: nobody
  • Delete comments: open permission on content

Won’t do (now)

  • No replies, no thread, just single comments
  • No editing, not moving markers, just create/delete comments
  • If the binary file changes, all shapes/comments will be removed by the backend. Later might add confirmation/notification function to let user control/know about this, but not now.
  • Will not truncate long comments, no “more/less” links.

Comment vs Office Online Editing

Store

  • file - which file the comment belongs to
  • who - who commented
  • when - DISCUSS: allow for comment modification? Store creation and modification dates?
  • Contents - DISCUSS: simple text?
  • Page number
  • Position
  • Order: height, width

Implementation plan

  • New Comment CTD. Place where the preview content is located, under the file in services.
  • Create a folder for holding comments under File's content template
  • Patch: create the comments folder under all(!) files with correct permissions
  • Create components in sn-document-viewer-react
  • Use these components in DMS demo
@herflis herflis transferred this issue from SenseNet/sn-document-viewer-react Dec 12, 2018
@kultsar kultsar changed the title Comments [sn-document-viewer-react] Comments Jan 19, 2019
@kultsar kultsar changed the title [sn-document-viewer-react] Comments [document-viewer-react] Comments Jan 19, 2019
@kultsar kultsar changed the title [document-viewer-react] Comments [document-viewer-react] Using the comments section Jan 25, 2019
@kultsar kultsar changed the title [document-viewer-react] Using the comments section [document-viewer-react] Comments Jan 25, 2019
@tusmester tusmester changed the title [document-viewer-react] Comments Comments in DocViewer Feb 19, 2019
@kultsar kultsar moved this from NEXT to NOW in Product Roadmap for sensenet Feb 27, 2019
@zoltanbedi zoltanbedi added DMS Issues related to the sn-dms-demo document-viewer-react labels Mar 27, 2019
@kultsar kultsar moved this from NOW to DONE in Product Roadmap for sensenet May 2, 2019
@herflis herflis added this to the Sprint 187 milestone Jun 18, 2019
@herflis herflis closed this as completed Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DMS Issues related to the sn-dms-demo document-viewer-react Epic
Projects
No open projects
Development

No branches or pull requests

3 participants