Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/forms auth fixes #108

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gallayl
Copy link
Contributor

gallayl commented Feb 7, 2019

No description provided.

@gallayl gallayl requested review from herflis and B3zo0 Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #108 into develop will decrease coverage by 0.04%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
- Coverage    87.17%   87.12%   -0.05%     
===========================================
  Files          104      104              
  Lines         3126     3130       +4     
  Branches       735      736       +1     
===========================================
+ Hits          2725     2727       +2     
- Misses         401      403       +2
Impacted Files Coverage Δ
...e/src/Authentication/FormsAuthenticationService.ts 96.15% <60%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a0817...e0950ff. Read the comment docs.

@herflis

herflis approved these changes Feb 8, 2019

@gallayl gallayl merged commit 19ffcd1 into develop Feb 8, 2019

4 of 6 checks passed

codecov/patch 60% of diff hit (target 87.17%)
Details
codecov/project 87.12% (-0.05%) compared to a49cbe3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@gallayl gallayl deleted the fix/forms-auth-fixes branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.