Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant type definition cleanup #111

Merged
merged 5 commits into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@gallayl
Copy link
Contributor

gallayl commented Feb 12, 2019

@gallayl gallayl requested review from herflis and B3zo0 Feb 12, 2019

Show resolved Hide resolved tslint.json Outdated

gallayl and others added some commits Feb 12, 2019

Apply suggestions from code review
Co-Authored-By: gallayl <gallayl@users.noreply.github.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #111 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
- Coverage    87.16%   87.15%   -0.02%     
===========================================
  Files          106      106              
  Lines         3133     3129       -4     
  Branches       736      737       +1     
===========================================
- Hits          2731     2727       -4     
  Misses         402      402
Impacted Files Coverage Δ
...-viewer-react/src/models/DocumentViewerSettings.ts 100% <ø> (ø) ⬆️
...n-search-react/src/Components/Fields/TypeField.tsx 97.22% <ø> (ø) ⬆️
...-document-viewer-react/src/components/PageList.tsx 42.66% <0%> (ø) ⬆️
.../sn-document-viewer-react/src/store/RootReducer.ts 100% <100%> (ø) ⬆️
packages/sn-client-core/src/Repository/Upload.ts 99.21% <100%> (ø) ⬆️
packages/sn-authentication-jwt/src/JwtService.ts 93.47% <100%> (ø) ⬆️
packages/sn-redux/src/reducers/selected.ts 100% <100%> (ø) ⬆️
packages/sn-control-mapper/src/ControlMapper.ts 100% <100%> (ø) ⬆️
packages/sn-redux/src/Store.ts 92.85% <100%> (-0.25%) ⬇️
...ckages/sn-client-core/src/Repository/Repository.ts 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00f65f...d6b65b7. Read the comment docs.

@B3zo0

B3zo0 approved these changes Feb 12, 2019

@gallayl gallayl merged commit fb6f798 into develop Feb 13, 2019

4 of 6 checks passed

codecov/patch 75% of diff hit (target 87.16%)
Details
codecov/project 87.15% (-0.02%) compared to c00f65f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@gallayl gallayl deleted the feature/remove-redundant-typedef branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.