Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant type definition cleanup #111

Merged
merged 5 commits into from
Feb 13, 2019
Merged

Conversation

gallayl
Copy link
Contributor

@gallayl gallayl commented Feb 12, 2019

tslint.json Outdated Show resolved Hide resolved
gallayl and others added 2 commits February 12, 2019 16:28
Co-Authored-By: gallayl <gallayl@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #111 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
- Coverage    87.16%   87.15%   -0.02%     
===========================================
  Files          106      106              
  Lines         3133     3129       -4     
  Branches       736      737       +1     
===========================================
- Hits          2731     2727       -4     
  Misses         402      402
Impacted Files Coverage Δ
...-viewer-react/src/models/DocumentViewerSettings.ts 100% <ø> (ø) ⬆️
...n-search-react/src/Components/Fields/TypeField.tsx 97.22% <ø> (ø) ⬆️
...-document-viewer-react/src/components/PageList.tsx 42.66% <0%> (ø) ⬆️
.../sn-document-viewer-react/src/store/RootReducer.ts 100% <100%> (ø) ⬆️
packages/sn-client-core/src/Repository/Upload.ts 99.21% <100%> (ø) ⬆️
packages/sn-authentication-jwt/src/JwtService.ts 93.47% <100%> (ø) ⬆️
packages/sn-redux/src/reducers/selected.ts 100% <100%> (ø) ⬆️
packages/sn-control-mapper/src/ControlMapper.ts 100% <100%> (ø) ⬆️
packages/sn-redux/src/Store.ts 92.85% <100%> (-0.25%) ⬇️
...ckages/sn-client-core/src/Repository/Repository.ts 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00f65f...d6b65b7. Read the comment docs.

@gallayl gallayl merged commit fb6f798 into develop Feb 13, 2019
@gallayl gallayl deleted the feature/remove-redundant-typedef branch February 13, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants