Feature/storybook5 #113
Merged
Feature/storybook5 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
========================================
Coverage 85.79% 85.79%
========================================
Files 109 109
Lines 3203 3203
Branches 761 761
========================================
Hits 2748 2748
Misses 455 455Continue to review full report at Codecov.
|
kultsar
suggested changes
Feb 20, 2019
There was a problem hiding this comment.
DateTimePicker, new mode, TypeError (note: this is a bug in previous version of storybook as well)
e.split is not a function
at t.setValue (https://sn-react-component-docs.netlify.com/static/iframe.eaeab064f68f7f59dc8c.bundle.js:1:19211)
at new t (https://sn-react-component-docs.netlify.com/static/iframe.eaeab064f68f7f59dc8c.bundle.js:1:18999)
at Ko (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:54981)
at ei (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:60314)
at Ci (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:74350)
at Di (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:74696)
at ca (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:79364)
at ua (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:79018)
at Li (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:77530)
at ba (https://sn-react-component-docs.netlify.com/static/vendors~iframe.a7ea2e5b105d0d0adbe3.bundle.js:93:85978)
moved scripts closer to the top of the package.json file
gallayl
approved these changes
Feb 25, 2019
kultsar
approved these changes
Feb 25, 2019
…lient into feature/storybook5
onemen
reviewed
Mar 14, 2019
| if (!module.built || module.external || !module.rawRequest) { | ||
| return | ||
| } | ||
| if (/\/src.+.tsx/.test(module.request)) { |
There was a problem hiding this comment.
This regexp is not work on windows.
/\/src.+.tsx/.test(module.request)windows separator is
this code work for me on windows
const ts = require("typescript");
+ const path = require("path");
class DocgenPlugin {
apply(compiler) {
+ const re = RegExp(`\\${path.sep}src.+\.tsx`);
compiler.hooks.compilation.tap("DocgenPlugin", compilation => {
compilation.hooks.seal.tap("DocgenPlugin", modules => {
const modulesToProcess = [];
compilation.modules.forEach(module => {
const { built, external, rawRequest, request } = module;
// Skip ignored / external modules
if (!module.built || module.external || !module.rawRequest) {
return;
}
- if (/\/src.+.tsx/.test(module.request)) {
+ if (re.test(module.request)) {
modulesToProcess.push(module);
}
});There was a problem hiding this comment.
You are right. I've never realized that. I use wsl in windows for development and our builds are on a linux machine. Thanks for pointing that out 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook upgrade ➡ v5
Things I changed in this pr:
removed unused dependencies
changed webpack.config.js to use ts-config-webpack-plugin, added a docgen plugin that generates proptables for typescript react components ( this reduced build time from 1.5 min to ~17 seconds)
withInfo added as a global decorator
removed muiTheme from stories
passed the notes as a parameter instead of
withMarkdownNotes()added storybook packages to nohoist - without nohoist storybook 5 runs with theming related errors because of duplicate packages - see (5.0.0-rc4 - cannot read property 'secondary' of undefined storybookjs/storybook#5706)Needs to be done: