Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal header for example apps #1231

Merged
merged 13 commits into from
Apr 9, 2021
Merged

Conversation

enikonemeth
Copy link
Contributor

It seems that storybook works only with these versions:
"ts-loader": "8.0.14"
,"webpack": "^4.44.2"

@enikonemeth enikonemeth added this to the Sprint 231 milestone Mar 8, 2021
@enikonemeth enikonemeth self-assigned this Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1231 (530b317) into develop (9196d0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1231   +/-   ##
========================================
  Coverage    93.50%   93.50%           
========================================
  Files          232      232           
  Lines         6315     6315           
  Branches      1674     1674           
========================================
  Hits          5905     5905           
  Misses         410      410           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9196d0a...530b317. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Mar 8, 2021

Site name Url Last deploy
sn-react-component-docs-dev https://606c8bc22e7da71d34b8bd66--sn-react-component-docs-dev.netlify.app Tue Apr 06 2021 - 16:26:43 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://606c8bc10dd37d1b59afa583--sn-app-dev.netlify.app Tue Apr 06 2021 - 16:26:42 GMT+0000 (Coordinated Universal Time)

Copy link
Contributor

@huszerlbence huszerlbence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thanks

@herflis herflis removed this from the Sprint 231 milestone Mar 17, 2021
packages/sn-universal-header/LICENSE Outdated Show resolved Hide resolved
packages/sn-universal-header/package.json Outdated Show resolved Hide resolved
packages/sn-universal-header/package.json Outdated Show resolved Hide resolved
packages/sn-universal-header/package.json Outdated Show resolved Hide resolved
packages/sn-universal-header/tsconfig.test.json Outdated Show resolved Hide resolved
@enikonemeth enikonemeth requested a review from taki9 April 6, 2021 16:20
@enikonemeth enikonemeth requested a review from taki9 April 8, 2021 14:08
@enikonemeth enikonemeth merged commit ab72798 into develop Apr 9, 2021
@enikonemeth enikonemeth deleted the feature/universal_header branch April 9, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants