Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #401 #412

Merged
merged 8 commits into from Oct 18, 2019
Merged

Bug fix #401 #412

merged 8 commits into from Oct 18, 2019

Conversation

atomanonymous
Copy link
Contributor

made the necessary changes

made the necessary changes
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2019

CLA assistant check
All committers have signed the CLA.

@zoltanbedi zoltanbedi changed the base branch from master to develop October 8, 2019 09:56
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #412 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #412   +/-   ##
========================================
  Coverage    89.55%   89.55%           
========================================
  Files          174      174           
  Lines         5207     5207           
  Branches      1332     1332           
========================================
  Hits          4663     4663           
  Misses         544      544

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2cd95...d4be04c. Read the comment docs.

@zoltanbedi
Copy link
Contributor

Hi @atomanonymous, thanks for the fix. Can you please remove the checkbox mentioned in the issue as well? Also please fix your lint issues.

Copy link
Contributor

@herflis herflis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💁‍♂️

@zoltanbedi zoltanbedi merged commit 5ff266d into SenseNet:develop Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants