Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview #791

Merged
merged 12 commits into from Aug 25, 2020
Merged

Preview #791

merged 12 commits into from Aug 25, 2020

Conversation

enikonemeth
Copy link
Contributor

No description provided.

@enikonemeth enikonemeth self-assigned this Aug 17, 2020
@sensenet
Copy link

sensenet bot commented Aug 17, 2020

Site name Url Last deploy
sn-react-component-docs-dev https://5f44afb977c0ad6a4ed439f7--sn-react-component-docs-dev.netlify.app Tue Aug 25 2020 - 06:29:14 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5f44afb6a10f3f7d73cd3299--sn-app-dev.netlify.app Tue Aug 25 2020 - 06:29:12 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #791 into develop will increase coverage by 0.04%.
The diff coverage is 64.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
+ Coverage    92.43%   92.47%   +0.04%     
===========================================
  Files          217      217              
  Lines         5859     5864       +5     
  Branches      1501     1502       +1     
===========================================
+ Hits          5416     5423       +7     
+ Misses         443      441       -2     
Impacted Files Coverage Δ
...document-viewer-react/src/context/api-settings.tsx 23.88% <0.00%> (ø)
...ocument-viewer-react/src/context/document-data.tsx 77.27% <63.15%> (+3.93%) ⬆️
...nt-viewer-react/src/context/preview-image-data.tsx 58.53% <66.66%> (+0.64%) ⬆️
...rc/components/DocumentViewerRegeneratePreviews.tsx 94.44% <83.33%> (-5.56%) ⬇️
packages/sn-client-core/src/Repository/Preview.ts 97.67% <100.00%> (ø)
...document-viewer-react/src/context/viewer-state.tsx 100.00% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efadc2e...821b502. Read the comment docs.

@enikonemeth enikonemeth marked this pull request as ready for review August 24, 2020 07:38
Copy link
Contributor

@herflis herflis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

@enikonemeth enikonemeth merged commit 2ceddc1 into develop Aug 25, 2020
@enikonemeth enikonemeth deleted the feature/preview branch August 25, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants