"Install log2ram" does not work from the menu

[fcarella]

line 46 in misc_commands.py is
subprocess.call("bash disable_swap.sh", shell=True)

doesnt look right, I think should be
subprocess.call("./scripts/disable_swap.sh ...", shell=True)

with some argument ..., not sure what though

[Slyke]

This is probably from your other bug #212 Give it a try now, and let me know if you still have troubles with it.

[fcarella]

Thanks for the quick responses. Will try out fixes when I get a chance.

…

On Thu, Dec 24, 2020, 4:14 PM Slyke ***@***.***> wrote: This is probably from your other bug #212 <#212> Give it a try now, and let me know if you still have troubles with it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#213 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQ7UYP76HBREMIHAZA5XNTSWOVK3ANCNFSM4VIQUJMQ> .

[fcarella]

Still doesnt work.

line 46 in misc_commands.py is
subprocess.call("bash disable_swap.sh", shell=True)

I still think the syntax is wrong but even so, if you look at "disable_swap.sh", theres nothing in there about log2ram.
The old IOTstack code does this (see line 410 @ https://github.com/gcgarner/IOTstack/blob/master/menu.sh):
...
git clone https://github.com/azlux/log2ram.git ~/log2ram
chmod +x ~/log2ram/install.sh
...

Hope this helps...

[Slyke]

Hey @fcarella , Looks like I forgot to actually commit the file and rename the command. Copy paste mistake! I just pushed another fix, and tested that begins to install it (but have not yet tested if install completes since I don't have access to a RPi right now).

[Slyke]

You can view the changes in this file: 123f35c, I'll close this issue, but please recomment if you continue to have issues with it.

[fcarella]

thanks. i'll try this out, let you know if there's any probs. And Merry Christmas!

…

On Fri, Dec 25, 2020 at 12:49 AM Slyke ***@***.***> wrote: You can view the changes in this file: 123f35c <123f35c>, I'll close this issue, but please recomment if you continue to have issues with it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#213 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQ7UYMET23NRK6TV7GNF3DSWQRXNANCNFSM4VIQUJMQ> .