-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEM-362] Updates for Bayer Canola workflow #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from some minor changes that enable us to do "classification" feature selection with the same module, the other major change to note in this file is a move to using a config
parameter which stores all of the data and config information for the different feature selection parts. This helps to clean things up a bit and to ensure that we aren't passing an incorrect value within one of the many function calls.
y="y_obs", | ||
hue="color", | ||
fit_reg=False, | ||
scatter_kws=scatter_kws, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the scatter_kws
argument to this function which helps us to customize the point attributes within a 1-to-1 plot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one minor question, everything looks good to me!
Updates for Bayer Canola workflow
What?
seaborn
version to ensure compatibility with other libraries (dependency resolution was failing)lasso_feature_selection()
. This is currently usingLinearSVC()
with anL1
penalty instead ofLasso()
to penalize features and, thereby, perform feature selection. Another option would beLogisticRegression()
with anL1
penalty.utils.py
to make ML workflow sleeker and allow for customized figures.Why?
CR Checklist
PR Checklist
_version.py
andpyproject.toml
poetry update
and committedpyproject.toml
andpoetry.lock
poetry run pre-commit autoupdate
Breaking Changes