Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEM-362] Updates for Bayer Canola workflow #65

Merged
merged 16 commits into from
May 12, 2023
Merged

Conversation

marissakivi
Copy link
Contributor

@marissakivi marissakivi commented May 8, 2023

Updates for Bayer Canola workflow

What?

  • Updated seaborn version to ensure compatibility with other libraries (dependency resolution was failing)
  • Added "classification" model capability to lasso_feature_selection(). This is currently using LinearSVC() with an L1 penalty instead of Lasso() to penalize features and, thereby, perform feature selection. Another option would be LogisticRegression() with an L1 penalty.
  • Some small adjustments to existing functions in utils.py to make ML workflow sleeker and allow for customized figures.

Why?

  • Fulfill on Bayer Canola Phase I

CR Checklist

  • Read through code changes. Any issues that you can see? Do the code changes make sense?

PR Checklist

  • Merged latest main
  • Updated version number
  • Version numbers match between package _version.py and pyproject.toml
  • Ran poetry update and committed pyproject.toml and poetry.lock
  • Ran poetry run pre-commit autoupdate

Breaking Changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some minor changes that enable us to do "classification" feature selection with the same module, the other major change to note in this file is a move to using a config parameter which stores all of the data and config information for the different feature selection parts. This helps to clean things up a bit and to ensure that we aren't passing an incorrect value within one of the many function calls.

y="y_obs",
hue="color",
fit_reg=False,
scatter_kws=scatter_kws,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the scatter_kws argument to this function which helps us to customize the point attributes within a 1-to-1 plot.

geoml/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tnigon tnigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one minor question, everything looks good to me!

@marissakivi marissakivi merged commit 8359762 into main May 12, 2023
2 checks passed
@marissakivi marissakivi deleted the DEM-362-update-seaborn branch May 12, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants