Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEM-416] Add filepath to make_1_to_1_plot() #68

Merged
merged 10 commits into from
Jan 23, 2024
Merged

[DEM-416] Add filepath to make_1_to_1_plot() #68

merged 10 commits into from
Jan 23, 2024

Conversation

tnigon
Copy link
Contributor

@tnigon tnigon commented Sep 1, 2023 •
edited
Loading

DEM-416 Add filepath to make_1_to_1_plot()

What?

  • Be able to pass filepath directly to make_1_to_1_plot()

Why?

  • Simplifies make_1_to_1_plot()
  • Allows us to use the DualPath context manager

CR Checklist

  • Do the changes look acceptable?

PR Checklist

  • Merged latest main
  • Updated version number
  • Version numbers match between package _version.py and pyproject.toml
  • Ran poetry update and committed pyproject.toml and poetry.lock
  • Ran poetry run pre-commit autoupdate

Breaking Changes

@tnigon tnigon merged commit 906bf01 into main Jan 23, 2024
2 checks passed
@tnigon tnigon deleted the DEM-416-refactor-cv branch January 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tnigon