Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayValues are missing metrics #64

Closed
ankitagojiya opened this issue Jan 31, 2024 · 11 comments
Closed

ArrayValues are missing metrics #64

ankitagojiya opened this issue Jan 31, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@ankitagojiya
Copy link

Hello @SeppPenner

As per issue #54 , I think you have added the array datatypes but its related values are still missing in metrics , pls refer below image which don't have any StringArrayValue or any array values

image

@SeppPenner
Copy link
Owner

This is mainly the same issue as #63, I guess.

@SeppPenner
Copy link
Owner

Update is planned for tomorrow.

@SeppPenner
Copy link
Owner

Version 1.3.2 is out soon and should fix this.

@ankitagojiya
Copy link
Author

ankitagojiya commented Feb 14, 2024

Hello @SeppPenner , That's not available in version 1.3.2.

I mean if you are giving support of string array than I am able to set the value of string array.

For e.g. If I select string data type then I will add value in StringValue property like StringValue="Data". Same way If I select datatype as StringArray on which property I have to filed that value?

Example of string array value : ["Test1","Test2"]

@shouidar
Copy link
Contributor

Looks like all the Array data types are not implemented yet. @SeppPenner please confirm.

@ankitagojiya
Copy link
Author

Yes , Also please can you reopen the issue if it's not implemented yet.

@SeppPenner
Copy link
Owner

I guess, you're right. I am currently testing with a broad unit test to find all issues with serialization here... Might take some time though. I hope to provide a solution until Saturday...

@SeppPenner SeppPenner reopened this Feb 14, 2024
@ankitagojiya
Copy link
Author

Appreciate it , Thank you

@SeppPenner
Copy link
Owner

I'm nearly done now. Some tests still fail because of issues with signed / unsigned values.

@malavvvakharia
Copy link

@SeppPenner, do you have a specific time for releasing this issue? I'm blocked by a bug.

@SeppPenner
Copy link
Owner

Fixed with https://github.com/SeppPenner/SparkplugNet/releases/tag/1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants