build: Use rollup-plugin-fast-typescript instead of @rollup/plugin-ty…

…pescript
Septh · Feb 2, 2024 · f6fbedb · f6fbedb
1 parent 107d910
commit f6fbedb
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 57 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -50,10 +50,10 @@
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-node-resolve": "^15.2.3",
     "@rollup/plugin-terser": "^0.4.4",
-    "@rollup/plugin-typescript": "^11.1.6",
     "@types/node": "^20.11.10",
     "rimraf": "^5.0.5",
     "rollup": "^4.9.6",
+    "rollup-plugin-fast-typescript": "^2.0.0",
     "rollup-plugin-node-externals": "^7.0.1",
     "sucrase": "^3.35.0",
     "tslib": "^2.6.2",

diff --git a/rollup.config.js b/rollup.config.js
@@ -2,7 +2,7 @@
 import nodeExternals from 'rollup-plugin-node-externals'
 import nodeResolve from '@rollup/plugin-node-resolve'
 import commonsJS from '@rollup/plugin-commonjs'
-import typescript from '@rollup/plugin-typescript'
+import typescript from 'rollup-plugin-fast-typescript'
 import terser from '@rollup/plugin-terser'
 import { defineConfig } from 'rollup'
 
@@ -16,48 +16,36 @@ export default defineConfig([
         output: {
             dir: 'lib',
             format: 'esm',
-            exports: 'named',
             generatedCode: 'es2015',
             sourcemap: true,
             sourcemapExcludeSources: true
         },
         plugins: [
             nodeExternals(),
             nodeResolve(),
-            commonsJS({ strictRequires: true }),
-            typescript()
-        ],
-        // Have to use Rollup's `external` option as rollup-plugin-node-externals
-        // only works for dependencies, not individual source files
-        external: /hooks\.js/
+            commonsJS(),
+            typescript('sucrase')
+        ]
     },
+
+    // This second Rollup configuration bundles Sucrase's parser to lib/cjs-transform.cjs
     {
         input: 'source/cjs-transform.cts',
         output: {
             file: 'lib/cjs-transform.cjs',
             format: 'commonjs',
-            exports: 'named',
-            generatedCode: 'es2015',
+            generatedCode: {
+                preset: 'es2015',
+                symbols: false
+            },
             esModule: false,
-            sourcemap: true,
-            sourcemapExcludeSources: true
+            sourcemap: false,
         },
         plugins: [
             nodeExternals(),
             nodeResolve(),
             commonsJS(),
-            // Not sure why but this is the only way I've found
-            // to have @rollup/plugin-typescript compile this file
-            // the way I wanted.
-            typescript({
-                include: './source/cjs-transform.cts',
-                exclude: './node-modules',
-                compilerOptions: {
-                    rootDir: undefined,
-                    outDir: undefined,
-                    module: undefined,
-                },
-            }),
+            typescript('sucrase'),
             terser()
         ],
         // sucrase has MANY circular dependencies :/

diff --git a/source/cjs-transform.cts b/source/cjs-transform.cts
@@ -1,5 +1,3 @@
-/// <reference types="./ambient.d.ts" />
-
 import { transform as _transform, type Transform } from 'sucrase'
 
 const transforms: Record<NodeJS.ModuleType, Transform[]> = {

diff --git a/source/esm-hooks.ts b/source/esm-hooks.ts
@@ -1,8 +1,9 @@
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { readFile } from 'node:fs/promises'
-import type { InitializeHook, ResolveHook, LoadHook, ModuleSource } from 'node:module'
-import transformer = require('./cjs-transform.cjs')
+import { type InitializeHook, type ResolveHook, type LoadHook, type ModuleSource, createRequire } from 'node:module'
+
+const transformer = createRequire(import.meta.url)('./cjs-transform.cjs')
 
 let self: string
 export const initialize: InitializeHook<string> = data => {