Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Bundle Updates Don't Seem to Be Applied #36

Closed
Jason-Morcos opened this issue Jun 21, 2020 · 2 comments · Fixed by #118
Closed

Default Bundle Updates Don't Seem to Be Applied #36

Jason-Morcos opened this issue Jun 21, 2020 · 2 comments · Fixed by #118
Labels
Bug Something isn't working Highest Priority

Comments

@Jason-Morcos
Copy link
Member

The latest changes to the SQL formatter bundle don't appear to be applied despite incrementing build&version numbers

@Jason-Morcos Jason-Morcos added this to To do in Release 2.1.x via automation Jun 21, 2020
@Jason-Morcos Jason-Morcos added Bug Something isn't working Highest Priority labels Jun 21, 2020
@jamesstout
Copy link
Contributor

We seem to have lost this from the build script:

https://github.com/sequelpro/sequelpro/blob/53cd722f37d6e1818206613d1234c0f2e21cb189/Scripts/build.sh#L100-L110

copy_default_bundles()
{
	log "Copying default bundles from '${SRCROOT}/SharedSupport/Default Bundles' to '${SHARED_SUPPORT_DIR}'"


	# Copy all Default Bundles to build product
	rm -rf "${SHARED_SUPPORT_DIR}/Default Bundles"


	mkdir -p "${SHARED_SUPPORT_DIR}/Default Bundles"


	cp -R "${SRCROOT}/SharedSupport/Default Bundles" "${SHARED_SUPPORT_DIR}"
}

@Jason-Morcos
Copy link
Member Author

Hmmm I wonder how we even do this in a sandbox world. Perhaps we bundle them into our Resources folder and then copy them into application support on first run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Highest Priority
Projects
No open projects
Release 2.1.x
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants