Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank space above tables and the filter search box #418

Closed
advicepyro opened this issue Oct 20, 2020 · 8 comments
Closed

Blank space above tables and the filter search box #418

advicepyro opened this issue Oct 20, 2020 · 8 comments
Labels
Bug Something isn't working Help wanted Extra attention is needed PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution

Comments

@advicepyro
Copy link

  • Sequel Ace Version: 2.2.1
  • macOS Version: 10.15.7
  • MySQL Version: 5.6.43

Description
Sometimes there is an expanding blank space above the list of tables and the filter search box. Refer to this screenshot for an example:

Screen Shot 2020-10-20 at 6 04 54 PM

This issue's been here for a while, since I believe when new tabs were added to Sequel Pro.

Steps To Reproduce

  1. Resize Sequel Ace to approximately half of the screen's size
  2. Quit and restart Sequel Ace. Then reconnect to a DB
  3. You'll notice there is some spacing above the tables list. Now zoom the app window
  4. After zooming, the space expands.
  5. Now that Sequel Ace is maximized, quit the app and restart it. Reconnect to your DB
  6. At the full size (in my case: HiDPI, like 2560x1440) the gap is now smaller. If you downsize the window the gap disappears.

Expected Behaviour
There should never be any gap between the top toolbar and the pane containing the list of tables.

Is Issue Present in Latest Beta?
Yes

@Jason-Morcos Jason-Morcos added PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution Bug Something isn't working Help wanted Extra attention is needed labels Oct 21, 2020
@Jason-Morcos
Copy link
Member

Yup, I've noticed this occasionally too. Not sure how to fix it, but would gladly review a PR aimed at doing so!

@juanvillegas
Copy link

sequel-ace

Is this the same problem? It's minor, but pretty annoying though.

macOS catalina 10.15.3
sequel ace 2.2.2 build 2104

@Kaspik
Copy link
Member

Kaspik commented Nov 2, 2020

We have a lot of changes in one PR, so let's see 2.3.0.

@Kaspik
Copy link
Member

Kaspik commented Nov 17, 2020

Is this still an issue on latest version?

@Jason-Morcos
Copy link
Member

Is this still an issue on latest version?

The root issue described in the issue is still an issue for me in the latest version. Hoping my PR from last night fixes it.
But I don't have the disappearing table list issue described above.

@advicepyro
Copy link
Author

Is this still an issue on latest version?

The root issue described in the issue is still an issue for me in the latest version. Hoping my PR from last night fixes it.
But I don't have the disappearing table list issue described above.

Was it this PR? #506
If so, do you know if that fix will make it to the 2.x builds?

If not that's fine, I can wait until 3.x makes it to release.

@Jason-Morcos
Copy link
Member

Is this still an issue on latest version?

The root issue described in the issue is still an issue for me in the latest version. Hoping my PR from last night fixes it.

But I don't have the disappearing table list issue described above.

Was it this PR? #506

If so, do you know if that fix will make it to the 2.x builds?

If not that's fine, I can wait until 3.x makes it to release.

Yup! It'll be a 3.0 and on fix (won't be in 2.0)!
If the issue isn't fixed by that PR though we'll definitely keep trying to figure it out!

@Kaspik
Copy link
Member

Kaspik commented Dec 4, 2020

I believe this is now resolved for 3.0.0

@Kaspik Kaspik closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Help wanted Extra attention is needed PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution
Projects
None yet
Development

No branches or pull requests

4 participants