Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound plays on menu appearance and on launch #489

Closed
corecoding opened this issue Nov 13, 2020 · 5 comments · Fixed by #520
Closed

Sound plays on menu appearance and on launch #489

corecoding opened this issue Nov 13, 2020 · 5 comments · Fixed by #520
Assignees
Labels
Bug Something isn't working Highest Priority
Projects

Comments

@corecoding
Copy link
Contributor

corecoding commented Nov 13, 2020

  • Sequel Ace Version: 2.2.2 (2104) and 2.3.0 (2111)
  • macOS Version: Catalina and Big Sur
  • MySQL Version: 5.6

Description
When right clicking in certain areas, a sound is played when the menu appears. Also, when opening Sequel Ace, the same alert sound plays.

Steps To Reproduce

  1. Go to one of the following: the Query window, or Query results, Content, and Table Info
  2. Right click to get the popup menu
  3. As said, it also happens when Sequel Ace launches for the first time.

Expected Behaviour
No sound is played

Is Issue Present in Latest Beta?
Not sure

Screen Shot 2020-11-13 at 2 54 13 PM

@Jason-Morcos
Copy link
Member

Jason-Morcos commented Nov 14, 2020

This is due to a bundles bug I believe. I always have my sounds muted lol. At least the at-launch one is bundles
We should probably fix this before the 3.0 jump @Sequel-Ace/all

@Jason-Morcos Jason-Morcos added this to To do in 2.x.x via automation Nov 14, 2020
@Jason-Morcos Jason-Morcos added Bug Something isn't working Highest Priority labels Nov 14, 2020
@jamesstout jamesstout self-assigned this Nov 14, 2020
@jamesstout jamesstout moved this from To do to Done in 2.x.x Nov 14, 2020
@Jason-Morcos Jason-Morcos linked a pull request Nov 19, 2020 that will close this issue
@Kaspik
Copy link
Member

Kaspik commented Nov 20, 2020

2.3.1 is out 🚀

@grigoryosifov
Copy link

grigoryosifov commented Nov 24, 2020

Hi, this sound still plays when I launch Sequel Ace for first time with 2.3.1. However the sound from the context menu seems fixed with this version.

@Jason-Morcos
Copy link
Member

@jamesstout @Kaspik reopening this issue as it's reporting still occurring on application open

@Kaspik
Copy link
Member

Kaspik commented Dec 4, 2020

I can't repro this anymore. So I'll close this and we will see with 3.0.0 release. (also James is doing a lot of work there)

@Kaspik Kaspik closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Highest Priority
Projects
No open projects
2.x.x
Done
Development

Successfully merging a pull request may close this issue.

5 participants