Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests #955

Closed
elgs opened this issue Mar 8, 2021 · 20 comments · Fixed by #961
Closed

Feature requests #955

elgs opened this issue Mar 8, 2021 · 20 comments · Fixed by #961
Assignees
Labels
Bug Something isn't working Feature Request New feature or request Fixed & Pending Release

Comments

@elgs
Copy link

elgs commented Mar 8, 2021

  1. Currently the minimum delay of auto complete is .5 seconds, can it be set to no delay?
  2. Can you please make auto complete tolerant to not typing the underscore? For example if I have a table some_awesome_table, the auto complete will be off if I type somea. Can you please make it tolerant to someaw, or even sat?
  3. Can you please show SQL preview before every DML is committed by the UI?

Thanks!

@jamesstout
Copy link
Contributor

jamesstout commented Mar 9, 2021

  1. Currently the minimum delay of auto complete is .5 seconds, can it be set to no delay?

Anyone see an issue with allowing 0s? You have to be a v. quick typist ... can get funky.

  1. Can you please make auto complete tolerant to not typing the underscore? For example if I have a table some_awesome_table, the auto complete will be off if I type somea. Can you please make it tolerant to someaw, or even sat?

Investigating....

  1. Can you please show SQL preview before every DML is committed by the UI?

We added a setting to alert you to 'destructive' SQL queries: #160. Does that suit your needs?

@elgs
Copy link
Author

elgs commented Mar 9, 2021

  1. Can you please show SQL preview before every DML is committed by the UI?

We added a setting to alert you to 'destructive' SQL queries: #160. Does that suit your needs?

Yes. Thanks. But I also observed that when I edit a field, sometimes it pops up a new window, and sometimes I am allowed to edit inline. When I edit it in the popup window, the DML preview doesn't show.

@jamesstout
Copy link
Contributor

Yes. Thanks. But I also observed that when I edit a field, sometimes it pops up a new window, and sometimes I am allowed to edit inline. When I edit it in the popup window, the DML preview doesn't show.

OK, will check.

@jamesstout
Copy link
Contributor

  1. Can you please make auto complete tolerant to not typing the underscore? For example if I have a table some_awesome_table, the auto complete will be off if I type somea. Can you please make it tolerant to someaw, or even sat?

There's a very hidden, non-discoverable keyboard combo, that will call fuzzy complete. On the query screen, there's an icon:

Screenshot 2021-03-09 at 8 32 39 PM

After typing say, somea, you can do this (with the Control modifier key when you click on the menu item)

2021-03-09 20 35 13

I've tweaked it a bit so that the table is at the top:

2021-03-09 20 01 22

What this weird modifier/menu selection does is run autoComplete for that word with fuzzySearch set to YES.

So .. trying something now ...

@jamesstout
Copy link
Contributor

How's this?

2021-03-09 21 00 10

This is with fuzzy set to always on...

@samuelbradshaw
Copy link

samuelbradshaw commented Mar 9, 2021

  1. Currently the minimum delay of auto complete is .5 seconds, can it be set to no delay?

Anyone see an issue with allowing 0s? You have to be a v. quick typist ... can get funky.

If the autocomplete calls too often, it can become laggy / jumpy as the app tries to keep up with the typing. I think it would be wise to have a debounce, if not a delay, or maybe a minimum delay of 0.1 seconds instead of 0.5. I don't have autocomplete on, so I haven't used it much – does it start the lookup 0.5 seconds after the user stops typing (debounce), or for every character typed (delay)?

@jamesstout
Copy link
Contributor

It calls doAutoCompletion (after delay) for every character typed, but only executes the auto-completion once, after the user stops typing and the delay, cancelling any other auto-completion requests.

@Jason-Morcos
Copy link
Member

It calls doAutoCompletion (after delay) for every character typed, but only executes the auto-completion once, after the user stops typing and the delay, cancelling any other auto-completion requests.

Hmmm it still seems a little crazy. A half second already is so fast. Maybe for now we could drop the delay down a bit, but I just don't see the need for 0.

Additionally, @elgs, in the future please open a feature request per each individual feature you're requesting. Combing three together, even if they're small, makes it very hard to track issues.

@Jason-Morcos Jason-Morcos added the Feature Request New feature or request label Mar 9, 2021
@jamesstout
Copy link
Contributor

Yes. Thanks. But I also observed that when I edit a field, sometimes it pops up a new window, and sometimes I am allowed to edit inline. When I edit it in the popup window, the DML preview doesn't show.

OK, will check.

I can't reproduce. Could you please give me some steps to follow? Thanks.

@elgs
Copy link
Author

elgs commented Mar 9, 2021

Yes. Thanks. But I also observed that when I edit a field, sometimes it pops up a new window, and sometimes I am allowed to edit inline. When I edit it in the popup window, the DML preview doesn't show.

OK, will check.

I can't reproduce. Could you please give me some steps to follow? Thanks.

CleanShot 2021-03-09 at 09 50 41

@elgs
Copy link
Author

elgs commented Mar 9, 2021

Additionally, @elgs, in the future please open a feature request per each individual feature you're requesting. Combing three together, even if they're small, makes it very hard to track issues.

@Jason-Morcos yeah, sorry for creating the mess.

@elgs
Copy link
Author

elgs commented Mar 9, 2021

How's this?

@jamesstout the fuzzy looks awesome. Thank you.

This is very opinionated. Others may not agree, but for me, the .5 second delay is to me what the DMV sloth clerk to the bunny officer. I love the user experience like this:

CleanShot 2021-03-09 at 09 56 48

@jamesstout
Copy link
Contributor

This is with fuzzy set to always on..

What do @Sequel-Ace/all think about enabling fuzzy matching for all non-SQL keywords?

@jamesstout
Copy link
Contributor

Maybe for now we could drop the delay down a bit, but I just don't see the need for 0.

I’ve implemented 0.0 but with a warning that pops up saying BEWARE: can cause weird output. Happy to remove though. Or set to 0.2?

@jamesstout jamesstout self-assigned this Mar 9, 2021
@elgs
Copy link
Author

elgs commented Mar 9, 2021

I think the first popup (leading of the debounce) should be 0, and you can do .1 or .2 of debounce. I don't see any reason to have any delay on the first trigger, or the leading of the debounce should be 0.

@elgs
Copy link
Author

elgs commented Mar 9, 2021

But I know it's easy for me to say it than for you to do it. So please feel to use your own judgement. My opinion may be weird at all and doesn't represent most other users wish.

I appreciate your fast responses and taking users requests seriously! Thank you!

@jamesstout
Copy link
Contributor

Yes. Thanks. But I also observed that when I edit a field, sometimes it pops up a new window, and sometimes I am allowed to edit inline. When I edit it in the popup window, the DML preview doesn't show.

OK, will check.

I can't reproduce. Could you please give me some steps to follow? Thanks.

Fixed.

@Jason-Morcos
Copy link
Member

This is with fuzzy set to always on..

What do @Sequel-Ace/all think about enabling fuzzy matching for all non-SQL keywords?

Fine by me!

I’ve implemented 0.0 but with a warning that pops up saying BEWARE: can cause weird output. Happy to remove though. Or set to 0.2?

Ehhh if a user wants to do 0 I'm okay with letting them do zero, especially if you're warning them when they do. Fine by me!

@elgs
Copy link
Author

elgs commented Mar 10, 2021

I’ve implemented 0.0 but with a warning that pops up saying BEWARE: can cause weird output. Happy to remove though. Or set to 0.2?

Ehhh if a user wants to do 0 I'm okay with letting them do zero, especially if you're warning them when they do. Fine by me!

Do you mind to explain what weird output could it possibly cause?

@Jason-Morcos
Copy link
Member

I’ve implemented 0.0 but with a warning that pops up saying BEWARE: can cause weird output. Happy to remove though. Or set to 0.2?

Ehhh if a user wants to do 0 I'm okay with letting them do zero, especially if you're warning them when they do. Fine by me!

Do you mind to explain what weird output could it possibly cause?

I think it has to potential to cause odd crashes and perhaps poor performance, so more bugs than unexpected outputs, but still something good to be aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Feature Request New feature or request Fixed & Pending Release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants