Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jnr-fuse work with jnr-ffi 2.1.8 #61

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Make jnr-fuse work with jnr-ffi 2.1.8 #61

merged 2 commits into from
Mar 1, 2020

Conversation

tornaia
Copy link
Contributor

@tornaia tornaia commented Jul 25, 2018

There was a change in jnr-ffi 2.1.8: jnr/jnr-ffi@82f954f#diff-6d69e8ad9f244cd630712601ca106d13

@SerCeMan
Copy link
Owner

Thank you for this! This seems to be unrelated to #60, so I'm going to revert the newest jnr-ffi for now, but I'll merge this once the dependency is upgraded again.

@SerCeMan
Copy link
Owner

We also need to try to introduce a better replacement for this reflections hack into JNR itself so that this problem will never happen again.

@SerCeMan
Copy link
Owner

ref #59

@SerCeMan
Copy link
Owner

@tornaia Do you know why the smoke tests in https://ci.appveyor.com/project/SerCeMan/jnr-fuse/build/1.0.100 were passing? Would you be able to modify https://github.com/SerCeMan/jnr-fuse/blob/master/src/test/java/ru/serce/jnrfuse/struct/MemoryFsTest.java to add a test case that covers this?

@SerCeMan
Copy link
Owner

SerCeMan commented Jul 25, 2018

@tornaia, I released 0.5.2.1 where I downgraded jnr-ffi. Could you please verify that this problem doesn't exist in 0.5.2.1?

@tornaia
Copy link
Contributor Author

tornaia commented Jul 25, 2018

@SerCeMan 0.5.2.1 works well. 👍
Now I look into the MemoryFsTest - I will come back to you when I have something.

@tornaia
Copy link
Contributor Author

tornaia commented Jul 25, 2018

Actually this smoke test on my machine* was always failing. Now it is always green. I still cannot explain the original issue... but I dont give up!

  • Windows 10 x64 1803/17134.167, WinFsp 2018.2 B1/winfsp-1.4.18170.msi, Oracle JDK10/java 10.0.1 2018-04-17

@SerCeMan
Copy link
Owner

SerCeMan commented Mar 1, 2020

Hey, @tobihagemann! I released a new version, 0.5.4 which includes this fix. I did a couple of rounds of testing, however, it'd be good if you could check that it solves the issue as well.

@kopavel
Copy link

kopavel commented Apr 11, 2020

In Java modular project problems can't be solved in that way.
With that package (jnr.ffi) any modular project are broken now.
Compile give error:
module jnr.fuse reads package jnr.ffi from both jnr.ffi and jnr.fuse
You need to remove that package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants