Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to change the domain for a site (Closes: #61) #62

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Document how to change the domain for a site (Closes: #61) #62

merged 1 commit into from
Feb 4, 2021

Conversation

ottok
Copy link
Contributor

@ottok ottok commented Feb 4, 2021

Include a full example that covers both wp search-replace and
applying redirects.

@ottok ottok mentioned this pull request Feb 4, 2021
Closed
@aurigit aurigit requested review from pekkakortelainen and removed request for slagsbulte and aurigit February 4, 2021 09:02
slagsbulte
slagsbulte approved these changes Feb 4, 2021
View reviewed changes
Copy link

@slagsbulte slagsbulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@elguitar elguitar self-requested a review February 4, 2021 09:05
elguitar
elguitar suggested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@elguitar elguitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! However there were no commas around say.

_posts/2019-04-08-redirect.md Outdated Show resolved Hide resolved
@ottok
Document how to change the domain for a site (Closes: #61)
dad14ad 
Include a full example that covers both `wp search-replace` and
applying redirects.
@ottok ottok requested a review from elguitar February 4, 2021 09:07
elguitar
elguitar approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@elguitar elguitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Abbreviation for "Looks Good To Me")

@ottok ottok merged commit dad14ad into master Feb 4, 2021
@github-pages github-pages bot temporarily deployed to github-pages February 4, 2021 09:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elguitar elguitar elguitar approved these changes

@slagsbulte slagsbulte slagsbulte approved these changes

@aurigit aurigit aurigit approved these changes

@pekkakortelainen pekkakortelainen Awaiting requested review from pekkakortelainen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ottok @elguitar @slagsbulte @aurigit