Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing slashes to permalinks #68

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Add trailing slashes to permalinks #68

merged 1 commit into from
Jun 8, 2021

Conversation

sjaks
Copy link
Contributor

@sjaks sjaks commented Jun 8, 2021

To ensure urls with and without trailing slasles take to the correct
page, include a slash at the end of permalinks

Kudos to @Moppa5 for finding a possible solution quickly

bundle install --path vendor/bundle
bundle exec jekyll serve

curl -L http://127.0.0.1:4000/docs/get-started/available-commands
curl -L http://127.0.0.1:4000/docs/get-started/available-commands/

To ensure urls with and without trailing slasles take to the correct
page, include a slash at the end of permalinks
@sjaks sjaks requested review from ypcs and Moppa5 June 8, 2021 06:30
@sjaks sjaks self-assigned this Jun 8, 2021
Copy link

@Moppa5 Moppa5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned curls work and correct pages are served when required. I tested by making some browsing on local environment and it works normally. As far as I'm concerned feel free to merge.

@sjaks sjaks merged commit 331ac4d into master Jun 8, 2021
@sjaks sjaks deleted the fix/permalinks branch June 8, 2021 07:02
@Moppa5 Moppa5 mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants