Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a container for CI usage #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fauust
Copy link

@fauust fauust commented Sep 5, 2022

The purpose of this is to build a container image to be usable in CI context.

TODO:

  • decide which registry to use (upstream decision)
  • add secrets of the registry in the upstream repo
  • implement tags/versions for containers

This would permit to use something like the following in CI systems:

docker run -it -v $(pwd):/mnt -w /mnt registry/Seravo/gnitpick:latest gnitpick <options>

And would probably speed up steps like https://salsa.debian.org/mariadb-team/mariadb-server/-/jobs/3189451.

Finally, it could also partially tackle #14 with something like the following in the pre-commit configuration.

    - repo: local
      hooks:
        - id: docker-gnitpick
          name: Run gnitpick with docker
          entry: Seravo/gnitpick:latest

The purpose of this is to build a container image to be usable in CI
context.

TODO:
  - decide which registry to use
  - add secrets of the registry
  - implement tags/versions
ypcs added a commit that referenced this pull request Dec 15, 2022
This allows running Gnitpick using a Docker container.

You can run the linting with

    docker run \
        -it \
        -v "$(pwd)/:/mnt" \
        ghcr.io/seravo/gnitpick:latest \
        gnitpick [options]

Based on the idea of @fauust <https://github.com/fauust>.

Related: <#29>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant