Ensure exec & substr compatibility #610
Merged
+84
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moppa5
added
enhancement
codebase
Moppa5
force-pushed
the
seravo-plugin-2/ensure-compatibility
branch
from
c7581f7
to
14eae55
Compare
JoosuaKoskinen
approved these changes
Aug 10, 2021
Moppa5
force-pushed
the
seravo-plugin-2/ensure-compatibility
branch
from
14eae55
to
12fe868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes in this PR?
Ensure that
execandsubstrare used properly in Seravo Plugin. I don't think we should call the day off / close those issues yet, but this is a good step forward.Why are we doing this? Any context or related work?
Related to #604 and #606