Do not install package on python 2 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewGlad
changed the title
dnicolson
reviewed
Feb 12, 2023
| @@ -1,7 +1,12 @@ | |||
| from setuptools import setup, find_packages | |||
| import sys | |||
| from codecs import open | |||
| from os import path | |||
|
|
|||
There was a problem hiding this comment.
Can this extra newline be removed?
There was a problem hiding this comment.
Imports sorted corresponding to PEP8: https://peps.python.org/pep-0008/#imports
Imports should be grouped in the following order:
Standard library imports.
Related third party imports.
Local application/library specific imports.
You should put a blank line between each group of imports.
Serchinastico
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python_requiresargument forsetuptools.setupdidn't work for my python2, so I just added a simple condition to check python version