Jasonroland patch 1 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serdnad
reviewed
Feb 11, 2022
|
Sounds good 👍👍
________________________________
From: Andres Gutierrez ***@***.***>
Sent: Friday, February 11, 2022 8:27:29 AM
To: Serdnad/aws_s3_upload ***@***.***>
Cc: jasonroland ***@***.***>; Author ***@***.***>
Subject: Re: [Serdnad/aws_s3_upload] Jasonroland patch 1 (PR #6)
@Serdnad commented on this pull request.
________________________________
In CHANGELOG.md<#6 (comment)>:
@@ -1,3 +1,7 @@
+## [1.2.1] - 2/2/2022
You've got 1.2.1 here, but changed the pubspec version to 1.3.0. Let's go with 1.3.0 here, since this is a new feature
⬇️ Suggested change
-## [1.2.1] - 2/2/2022
+## [1.3.0] - 2/2/2022
—
Reply to this email directly, view it on GitHub<#6 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE6BI2IYP7OWIOUBYEF5H2LU2UFEDANCNFSM5NY4OGFQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hey @jasonroland, thanks for the contribution! The new additions look good. What's the reasoning behind deleting .gitignore, .metadata, and policy.dart though? |
|
No reason, my first time submitting a PR and tried doing it via web but I messed up the upload.
…________________________________
From: Andres Gutierrez ***@***.***>
Sent: Friday, February 11, 2022 8:28:50 AM
To: Serdnad/aws_s3_upload ***@***.***>
Cc: jasonroland ***@***.***>; Mention ***@***.***>
Subject: Re: [Serdnad/aws_s3_upload] Jasonroland patch 1 (PR #6)
Hey @jasonroland<https://github.com/jasonroland>, thanks for the contribution!
The new additions look good. What's the reasoning behind deleting .gitignore, .metadata, and policy.dart though?
—
Reply to this email directly, view it on GitHub<#6 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AE6BI2K7VEFYF3LP2YSDCVDU2UFJFANCNFSM5NY4OGFQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Do you want me to resubmit it using vscode where you should be able to get all those files too? |
Co-authored-by: Andres Gutierrez <andresgutierrez535@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to choose acl policy added. This was necessary as we are uploading files to a private bucket.