Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibJSGCVerifier: Complain about JS::Handle in members of GC-allocated object #23880

Closed
kalenikaliaksandr opened this issue Apr 7, 2024 · 2 comments · Fixed by #24422
Closed
Labels
enhancement New feature or request fund This issue can be funded via polar.sh

Comments

@kalenikaliaksandr
Copy link
Contributor

kalenikaliaksandr commented Apr 7, 2024

JS::Handle (strong root) could reach GC-allocated that owns it, creating reference cycle.
Example of leak fix efa305d (#23553)

Funding

  • We're currently trying Polar.sh where you can help fund the work on this issue.
  • Contributor(s) receive the funding once the issue is completed & confirmed.
Fund with Polar
@mattco98
Copy link
Collaborator

mattco98 commented May 19, 2024

It looks like AsyncFunctionDriverWrapper has a JS::Handle member that is intentional, is there maybe a different mechanism we could use or something? Not sure how I would differentiate that case specifically from any other usage of JS::Handle in a field.

Copy link
Member

Thank you @mattco98 for contributing to close this issue! ⭐

The rewards from this issue, totaling $25, has been shared with you.

What now?

  1. Create a Polar account
  2. See incoming rewards & setup Stripe to receive them
  3. Get payouts as backers finalize their payments

If you already have a Polar account setup, you don't need to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fund This issue can be funded via polar.sh
Projects
None yet
3 participants