Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Add gn build for lagom as an option to serenity.sh #23894

Open
3 tasks
ADKaster opened this issue Apr 8, 2024 · 0 comments
Open
3 tasks

Meta: Add gn build for lagom as an option to serenity.sh #23894

ADKaster opened this issue Apr 8, 2024 · 0 comments
Labels
enhancement New feature or request task list This issue contains a list of tasks.

Comments

@ADKaster
Copy link
Member

ADKaster commented Apr 8, 2024

The GN build (https://github.com/SerenityOS/serenity/tree/master/Meta/gn#readme) seems to be relatively stable at the moment. To promote more usage of the build, and get some experience for how nicely it plays with IDEs folks are using, we should add more integration for it into the normal build scripts.

  • Add option for serenity.sh to use gn to create the build directory for Lagom. Likely in a separate build directory from the CMake build to avoid conflicts with the serenity build.
  • Add code to generate a suitable args.gn on Linux systems. On macOS with homebrew, things will "just work". On Ubuntu, we need to run qmake6 -query to find the proper directories for Qt6 to build Ladybird, and to write down a suitable C++ compiler version.

Future goal:

  • Use the JSON ide script output option for gn gen to generate CMake files good enough to make CLion happy.
@ADKaster ADKaster added enhancement New feature or request task list This issue contains a list of tasks. labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task list This issue contains a list of tasks.
Projects
None yet
Development

No branches or pull requests

1 participant