Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGfx: Google Doodle Issue #2 and download GIF issue #3291

Closed
Lubrsi opened this issue Aug 25, 2020 · 6 comments
Closed

LibGfx: Google Doodle Issue #2 and download GIF issue #3291

Lubrsi opened this issue Aug 25, 2020 · 6 comments

Comments

@Lubrsi
Copy link
Member

Lubrsi commented Aug 25, 2020

Here's how the current Google doodle appears:
2yopdpeg7H

I imagine it has something to do with this:

Unexpected application extension size: 1135

For some reason, it doesn't start animating until you resize the window.

While I was at it, I noticed the download GIF nows shows a background colour when the page flies across:
mLuxE4Sdvn

@alimpfard
Copy link
Member

Unexpected application extension size: 1135

That might be an ICC profile, starting at offset 0x320. it's the first app extension that appears in the file, and it just defines color stuff, so likely not related to that issue.

@awesomekling
Copy link
Contributor

cc @peterdn

@awesomekling
Copy link
Contributor

Looks like an interlaced animated GIF :)

@tomuta
Copy link
Collaborator

tomuta commented Aug 25, 2020

For some reason, it doesn't start animating until you resize the window.

It does for me. Looks the same, though.

@peterdn
Copy link
Contributor

peterdn commented Aug 25, 2020

Thanks, will have a look at adding support for interlaced GIFs at the weekend 😄

Unexpected application extension size: 1135

I saw this same thing in a previous Google Doodle and it was some embedded XMP metadata that was not necessary to decode the image itself. Possibly the same thing here.

@Lubrsi
Copy link
Member Author

Lubrsi commented Aug 30, 2020

Fixed by #3345.

@Lubrsi Lubrsi closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants