Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent removing persists after user canceled editing {bug} #60

Closed
ruslangaripov opened this issue Sep 26, 2016 · 7 comments
Closed

Parent removing persists after user canceled editing {bug} #60

ruslangaripov opened this issue Sep 26, 2016 · 7 comments
Assignees
@Serg-Norseman
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@ruslangaripov
Copy link
Collaborator

Steps to reproduce:

  1. Open a person in editor window, for example, 'BLYTHE William Jefferson',
  2. Click "Disconnect father" button,
  3. Answer "Yes" to confirmation,
  4. Click "Cancel" button,
  5. Edit the same person again ('BLYTHE William Jefferson'). Now the person has no father, despite the fact that user has pressed "Cancel" button previously.

gk-bug-4
@ruslangaripov ruslangaripov mentioned this issue Sep 26, 2016
Closed
@Serg-Norseman Serg-Norseman self-assigned this Sep 26, 2016
@Serg-Norseman Serg-Norseman added enhancement New feature or request help wanted Extra attention is needed bug Something isn't working labels Sep 26, 2016
@Serg-Norseman
Copy link
Owner

This is a great find! This problem revealed at least three other flaws.

@ruslangaripov
Copy link
Collaborator Author

A small ticket that will lead to big changes 😈

@Serg-Norseman
Copy link
Owner

Oh yeah! 👍 😄

@Serg-Norseman
Copy link
Owner

Closed in error instead of 59.

@Serg-Norseman Serg-Norseman reopened this Sep 26, 2016
@Serg-Norseman
Copy link
Owner

Serg-Norseman commented Sep 27, 2016 •
edited

In the evening I sending the current implementation for this issue...
while only partial, the problem is quite big...

@ruslangaripov
Copy link
Collaborator Author

👍 I'm looking forward to your patch. Even partial one.

Serg-Norseman added a commit that referenced this issue Sep 27, 2016
@Serg-Norseman
First experimental part to support cancellation in dialogs (#60)
182a8bb
@Serg-Norseman
Copy link
Owner

Serg-Norseman commented Sep 27, 2016 •
edited

Now, it is only the parents of an individual and spouses in families

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Serg-Norseman Serg-Norseman

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Serg-Norseman @ruslangaripov