Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest chrome driver version #445

Merged
merged 8 commits into from
Oct 2, 2022

Conversation

alexander-gridnev
Copy link
Contributor

@alexander-gridnev alexander-gridnev commented Sep 28, 2022

@matthiasha
Copy link

Thanks Alexander, this works for my colleague!

@rain01
Copy link

rain01 commented Sep 29, 2022

Thank you Alexander. Any idea when this will be released? Is there a workaround until then?
I tried using latest_release_url but it seems this is rather just used for version checking not passing url of the latest download link?

@Jfromtheroc
Copy link

Having the same issue, thank you

@duncanariey
Copy link

I'm also seeing this issue. Thank you for the quick fix, would love to see it released soon!

@alexander-gridnev
Copy link
Contributor Author

@rain01 yeah, latest_release_url it's the url which used to check latest available version (returns string "106.0.5249.61" atm), so, i just use direct link to the commit in requirements files (like this - git+https://github.com/alexander-gridnev/webdriver_manager@62671021ee5456c315d9d0eae3f2428d6cec955f#egg=webdriver-manager)

Hey @aleksandr-kotlyar @SergeyPirogov, could you guys review the change?

@@ -29,10 +30,22 @@ def get_os_type(self):
return os_type

if is_arch(os_type):
return f"{os_type.replace('_m1', '')}_m1"
return "mac_arm64"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but if it's arch that is not mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous if statement checks "none mac" case, and returns os_type as is.

But yeah, is_arch function is kind of misleading atm, i was even thinking to rename to "is_mac_arch" and add to inside function check if that's mac or not, cause it's always used after is_mac check in current codebase

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I always wondered, why the function is named is_arch and it isn't is_arm? Isn't is_arch coming from is architecture (which can be any arch)?

@SergeyPirogov SergeyPirogov merged commit dc73f4a into SergeyPirogov:master Oct 2, 2022
@SergeyPirogov
Copy link
Owner

Ok will merge it. @alexander-gridnev thank you

@jakemraz
Copy link

jakemraz commented Oct 4, 2022

https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip has not been found.

but we can find https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac_arm64.zip

after this patch was applied, my webdriver manager made a following error
"ValueError: There is no such driver by url https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip"

Please check this

@VladimirPodolian
Copy link

@SergeyPirogov can you please release this fix in pypi as soon as possible ?

@0x94494944
Copy link

https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip has not been found.

but we can find https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac_arm64.zip

after this patch was applied, my webdriver manager made a following error "ValueError: There is no such driver by url https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip"

Please check this

Having the same problem here...

@Pr0s3lyt3
Copy link

Same issue as well, please assist!

@alexander-gridnev
Copy link
Contributor Author

Hi @Pr0s3lyt3, @ambitionist, could show output of such snippet:

from webdriver_manager.chrome import ChromeDriverManager
from webdriver_manager.core.utils import ChromeType

manager = ChromeDriverManager(chrome_type=ChromeType.CHROMIUM)

print(manager.driver.get_os_type())
print(manager.driver.get_version())
print(manager.driver.get_url())

Also, on which macs do you run it?

@0x94494944
Copy link

Output:
mac64_m1
106.0.5249.61
https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip

I'm using a mac m1 2020 with Monterey 12.6

@alexander-gridnev
Copy link
Contributor Author

hmm, could you show output pip freeze | grep webdriver-manager in shell? I feel like you still have wrong version

@alexander-gridnev
Copy link
Contributor Author

here is what i see:

# pip freeze | grep webdriver-manager
webdriver-manager @ git+https://github.com/alexander-gridnev/webdriver_manager@62671021ee5456c315d9d0eae3f2428d6cec955f

@0x94494944
Copy link

here is what i see:

# pip freeze | grep webdriver-manager
webdriver-manager @ git+https://github.com/alexander-gridnev/webdriver_manager@62671021ee5456c315d9d0eae3f2428d6cec955f
# pip freeze | grep webdriver-manager                                                                           
webdriver-manager==3.8.3

@alexander-gridnev
Copy link
Contributor Author

try to uninstall and install current master:

pip uninstall webdriver_manager
pip install git+https://github.com/SergeyPirogov/webdriver_manager@master

@ShasTheMass
Copy link

I confirm this is what I saw too

$ pip freeze | grep webdriver
webdriver-manager==3.8.3

But if you do this instead:

$ pip install git+https://github.com/SergeyPirogov/webdriver_manager.git@master#egg=webdriver-manager

then you shall get:

$ pip freeze | grep webdriver
webdriver-manager @ git+https://github.com/SergeyPirogov/webdriver_manager.git@dd39e872f722b6f3e43d9146f25b1983231ccb80

@alexander-gridnev alexander-gridnev deleted the chrome-bugfix branch October 10, 2022 10:22
@alexander-gridnev alexander-gridnev restored the chrome-bugfix branch October 10, 2022 10:52
@0x94494944
Copy link

try to uninstall and install current master:

pip uninstall webdriver_manager
pip install git+https://github.com/SergeyPirogov/webdriver_manager@master

Thanks, I needed to also install the "packaging" dependency to make it work but it fixes it!

alyanser added a commit to alyanser/dolladolla that referenced this pull request Oct 10, 2022
* Update the deprecated code

Adjusting the code with the new update on webdriver_manager #445: 
SergeyPirogov/webdriver_manager#445

* Update dolla.py

Co-authored-by: staz <74452129+alyanser@users.noreply.github.com>
kewka added a commit to kewka/hcaptcha-challenger that referenced this pull request Oct 10, 2022
@cmin764
Copy link

cmin764 commented Oct 11, 2022

Can we please release this as asked here as well?

@EwoutH
Copy link

EwoutH commented Oct 14, 2022

I'm having this issue as well. @SergeyPirogov could you please tag a release?

@SergeyPirogov
Copy link
Owner

Hello, could you provide a pr with version update to 3.8.4

@EwoutH
Copy link

EwoutH commented Oct 14, 2022

Hello, could you provide a pr with version update to 3.8.4

That's normally something that a maintainer does.

But if you want that, is there a maintenance branch I can merge into?

@chrisgraham24
Copy link

I am still seeing this issue -- ValueError: There is no such driver by url https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip

@mpineyrozaelot
Copy link

Hello guys, any idea on when are we going to release the last version?

@anhnlh anhnlh mentioned this pull request Oct 17, 2022
@chrisgraham24
Copy link

3.8.4 did not fix this for me.

@aleksandr-kotlyar aleksandr-kotlyar linked an issue Feb 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: There is no such driver by url