Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed marker #480

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Conversation

faissaloux
Copy link
Contributor

Hello 👋🏻

In this PR I have added py.typed marker that is missing so that mypy won't complain about it.

@faissaloux
Copy link
Contributor Author

@SergeyPirogov 👋🏻

This is weird, first time I've got this error:

image

So I have added the LICENSE.chromedriver to the list, and now got the opposite:

image

Are tests working well!

@aleksandr-kotlyar aleksandr-kotlyar linked an issue Feb 21, 2023 that may be closed by this pull request
…nto pytyped

# Conflicts:
#	tests/test_downloader.py
@aleksandr-kotlyar aleksandr-kotlyar merged commit e8815ac into SergeyPirogov:master Feb 21, 2023
@faissaloux faissaloux deleted the pytyped branch February 22, 2023 01:07
@faissaloux
Copy link
Contributor Author

@aleksandr-kotlyar Can I know when v3.8.6 gonna be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing mypy stubs
2 participants