Fix #422 #442 #464 #494
Merged
Fix #422 #442 #464 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erferer other tests
…t_browser_version_from_os()`
…_version_to_download()` Driver.get_driver_version_to_download returns: - version from version parameter if version not None or "latest"; - latest, if version is "latest" or browser could not been determined; - determined browser version driver in all others ways.
description of fix: Now if version="latest" - downloads LATEST_RELEASE for Chrome/Chromiums and LATEST_STABLE for Edge if version=x.x.x - downloads x.x.x if version is None - tries to determine installed browser version, and if fail - downloads like "latest" - LATEST_RELEASE also: - no more Exception if browser not determined - optimize os_type() calls and some var namings - no more rewriting self._version
…h by some reasons (for example: not enough space on disk or not enough rights, or antivirus deletion)
…ache_key_driver_version with unified method DriverCache::get_cache_key_driver_version()
…key for diff usage places in DriverCache class. Also: - rename get_metadata to load_metadata_content - pass into __save_metadata 1 param: driver instead of 4 params - clean save_file_to_cache from redundant vars
This was
linked to
issues
Mar 9, 2023
|
Great job @aleksandr-kotlyar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #415
Resolves #422
Resolves #442
Resolves #464
Fixed queries to GitHubApi when driver found in cache for firefox/ie/opera.
Fixed falling with Exception if browser was not determined, no more falls with this reason from now on.
Fixed metadata and paths storage for "latest".
Fixed version download logic for Chrome/Edge:
Plus:
Great refactoring in Driver and DriverCache which should make them easier to read and support.
Great function call optimizations to make easier to debug webdriver-manager issues.