Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct os_type determination while on cygwin #575

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add correct os_type determination while on cygwin #575

merged 1 commit into from
Jul 28, 2023

Conversation

wwakabobik
Copy link
Contributor

  • Add correct os_type determination while on cygwin
  • Up-to date README.md

@SergeyPirogov SergeyPirogov merged commit 18268c1 into SergeyPirogov:master Jul 28, 2023
4 of 5 checks passed
@SergeyPirogov
Copy link
Owner

@wwakabobik Thanks

@wwakabobik
Copy link
Contributor Author

@wwakabobik Thanks

You're welcome. Tried to make docs actual :)

@rain01
Copy link

rain01 commented Aug 2, 2023

https://github.com/SergeyPirogov/webdriver_manager/pull/575/files#diff-ba18bbaec92175d45609614ad55533eedd3f40c3902a34b3e31f6f068cbb7970R42
Shouldn't this be:

elif pl == "win32" or pl == "cygwin":

@SergeyPirogov
Copy link
Owner

@rain01 open a pr please

@wwakabobik wwakabobik deleted the 4.0.1 branch August 2, 2023 20:29
@wwakabobik wwakabobik restored the 4.0.1 branch August 2, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wwakabobik @SergeyPirogov @rain01