Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Chrome Download for Versions < 113 #583

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

mjblue
Copy link
Contributor

@mjblue mjblue commented Jul 31, 2023

when querying http://chromedriver.storage.googleapis.com/latest_release the versions do not have the last build version and so need to be stripped.

This fix is suggested by @shenchucheng.

I have added a test for this scenario of an detected version < 113

@SergeyPirogov
Copy link
Owner

Will this work for 115?

@SergeyPirogov SergeyPirogov merged commit 322e160 into SergeyPirogov:master Jul 31, 2023
4 of 5 checks passed
@mjblue
Copy link
Contributor Author

mjblue commented Jul 31, 2023

Will this work for 115?

For versions above 113 it will return before hitting this new logic:

if determined_browser_version is not None and version.parse(determined_browser_version) >= version.parse("113"):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants