New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium support v2 #97
Chromium support v2 #97
Conversation
… cached versions of chrome tests
Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-03-06 09:07:57 UTC |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 87.80% 87.96% +0.16%
==========================================
Files 9 9
Lines 369 374 +5
Branches 46 46
==========================================
+ Hits 324 329 +5
Misses 30 30
Partials 15 15
Continue to review full report at Codecov.
|
…ings and couldn't be fixed normally
@aleksandr-kotlyar good, merged |
Chromium support v2 (SergeyPirogov#97)
Goal
Add Chromium support
Reason
For testing Chromium. Mainly for linux distributions, which doesn't have google-chrome in their repositories.
Solution
Parametrized
ChromeDriverManager()
withchrome_type: 'google-chrome' / 'chromium'
and 'google-chrome' by default.Previous version (PR #94) has duplicated code for Chrome and Chromium drivers. So here is v2.
Resolves #94
Resloves #93