Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium support v2 #97

Merged

Conversation

aleksandr-kotlyar
Copy link
Collaborator

@aleksandr-kotlyar aleksandr-kotlyar commented Mar 6, 2020

Goal

Add Chromium support

Reason

For testing Chromium. Mainly for linux distributions, which doesn't have google-chrome in their repositories.

Solution

Parametrized ChromeDriverManager() with chrome_type: 'google-chrome' / 'chromium' and 'google-chrome' by default.

Previous version (PR #94) has duplicated code for Chrome and Chromium drivers. So here is v2.

class ChromeDriver(chrome_type=ChromeType.GOOGLE)
...
class ChromeType(object):
    GOOGLE = 'google-chrome'
    CHROMIUM = 'chromium'

Resolves #94
Resloves #93

@pep8speaks
Copy link

pep8speaks commented Mar 6, 2020

Hello @aleksandr-kotlyar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:80: E501 line too long (85 > 79 characters)
Line 16:80: E501 line too long (84 > 79 characters)

Line 15:80: E501 line too long (96 > 79 characters)

Line 94:80: E501 line too long (100 > 79 characters)
Line 95:80: E501 line too long (99 > 79 characters)
Line 99:80: E501 line too long (88 > 79 characters)
Line 100:80: E501 line too long (94 > 79 characters)

Comment last updated at 2020-03-06 09:07:57 UTC

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #97 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   87.80%   87.96%   +0.16%     
==========================================
  Files           9        9              
  Lines         369      374       +5     
  Branches       46       46              
==========================================
+ Hits          324      329       +5     
  Misses         30       30              
  Partials       15       15              
Impacted Files Coverage Δ
webdriver_manager/utils.py 76.47% <0.00%> (-2.00%) ⬇️
webdriver_manager/driver.py 83.70% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d816d...e4f60d5. Read the comment docs.

@SergeyPirogov SergeyPirogov merged commit 25d0dd1 into SergeyPirogov:master Mar 13, 2020
@SergeyPirogov
Copy link
Owner

@aleksandr-kotlyar good, merged

aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants