Event table purger #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergiiKram
reviewed
Jul 22, 2023
| .Where(x => x.EventTime < olderThanUtc && | ||
| x.IsProcessed == true) | ||
| .Take(Options.BatchSize) | ||
| .ExecuteDeleteAsync(cancellationToken); |
There was a problem hiding this comment.
Do we need db.SaveChangesAsync here?
There was a problem hiding this comment.
SergiiKram
reviewed
Jul 22, 2023
|
|
||
| await WorkflowPurger.PurgeWorkflows(WorkflowStatus.Complete, DateTime.UtcNow); | ||
| await EventsPurger.PurgeEvents(DateTime.UtcNow); | ||
| await EventsPurger.PurgeEvents(DateTime.UtcNow); |
SergiiKram
merged commit 9aa6cc9
into
SergiiKram:idempotent-workflow-start
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Implemented Event table purger
Describe your implementation or design
Implemented EventsPurger in a similar way to WorkflowPurger.
Tests
Yes
Breaking change
No
Additional context
We had 16 million rows and it broke our PROD.