memory provider idempotency updates #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starushykart
changed the title
SergiiKram
reviewed
May 10, 2024
| private readonly MemoryPersistenceProvider _provider = new(); | ||
|
|
||
| [Fact] | ||
| public void Should_Throw_If_Workflow_With_Same_Reference_Already_Exist() |
There was a problem hiding this comment.
It's already covered by the existing test, so I'll delete this file from PR.
…oryPersistenceProviderTests.cs
SergiiKram
merged commit b7fe607
into
SergiiKram:idempotent-workflow-start
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Added idempotency into the memory persistence provider
Describe your implementation or design
simple check
Tests
Yes