Fix analyzers triggering on unrelated partial methods

Sergio0694 · Jan 6, 2024 · 09b2288 · 09b2288
1 parent 40874d5
commit 09b2288
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/...ceGenerators/Diagnostics/Analyzers/InvalidD2DPixelShaderSourceMethodReturnTypeAnalyzer.cs b/...ceGenerators/Diagnostics/Analyzers/InvalidD2DPixelShaderSourceMethodReturnTypeAnalyzer.cs
@@ -1,5 +1,6 @@
 using System.Collections.Immutable;
 using System.Linq;
+using ComputeSharp.SourceGeneration.Extensions;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Diagnostics;
 using static ComputeSharp.SourceGeneration.Diagnostics.DiagnosticDescriptors;
@@ -42,6 +43,12 @@ public override void Initialize(AnalysisContext context)
                     return;
                 }
 
+                // Ignore methods without [D2DPixelShaderSource]
+                if (!methodSymbol.HasAttributeWithType(d2DPixelShaderSourceAttributeSymbol))
+                {
+                    return;
+                }
+
                 // Emit a diagnostic if the return type is not ReadOnlySpan<byte>
                 if (!SymbolEqualityComparer.Default.Equals(methodSymbol.ReturnType, readOnlySpanOfByteSymbol))
                 {

diff --git a/...ors/Diagnostics/Analyzers/MissingD2DCompileOptionsOnD2DPixelShaderSourceMethodAnalyzer.cs b/...ors/Diagnostics/Analyzers/MissingD2DCompileOptionsOnD2DPixelShaderSourceMethodAnalyzer.cs
@@ -39,6 +39,12 @@ public override void Initialize(AnalysisContext context)
                     return;
                 }
 
+                // Ignore methods without [D2DPixelShaderSource]
+                if (!methodSymbol.HasAttributeWithType(d2DPixelShaderSourceAttributeSymbol))
+                {
+                    return;
+                }
+
                 // Emit a diagnostic if there is no compile options available at any level
                 if (!methodSymbol.HasAttributeWithType(d2DCompileOptionsAttributeSymbol) &&
                     !methodSymbol.ContainingAssembly.HasAttributeWithType(d2DCompileOptionsAttributeSymbol))

diff --git a/...tors/Diagnostics/Analyzers/MissingD2DShaderProfileOnD2DPixelShaderSourceMethodAnalyzer.cs b/...tors/Diagnostics/Analyzers/MissingD2DShaderProfileOnD2DPixelShaderSourceMethodAnalyzer.cs
@@ -39,6 +39,12 @@ public override void Initialize(AnalysisContext context)
                     return;
                 }
 
+                // Ignore methods without [D2DPixelShaderSource]
+                if (!methodSymbol.HasAttributeWithType(d2DPixelShaderSourceAttributeSymbol))
+                {
+                    return;
+                }
+
                 // Emit a diagnostic if there is no shader profile available at any level
                 if (!methodSymbol.HasAttributeWithType(d2DShaderProfileAttributeSymbol) &&
                     !methodSymbol.ContainingAssembly.HasAttributeWithType(d2DShaderProfileAttributeSymbol))