Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [D2DGeneratedPixelShaderDescriptor] attribute and use FAWMN #587

Merged
merged 20 commits into from
Oct 3, 2023

Conversation

Sergio0694
Copy link
Owner

Description

This PR adds the new [D2DGeneratedPixelShaderDescriptor] attribute to trigger the D2D1 source generator, and also includes a code fixer to automatically add it to shader types, along with several new diagnostic analyzers to provide useful errors.

API breakdown

namespace ComputeSharp.D2D1;

[AttributeUsage(AttributeTargets.Struct, AllowMultiple = false)]
public sealed class D2DGeneratedPixelShaderDescriptorAttribute : Attribute
{
}

@Sergio0694 Sergio0694 added optimization 🚀 Performance improvement to existing APIs breaking change 💣 A change that is either binary or source breaking labels Oct 1, 2023
@Sergio0694 Sergio0694 force-pushed the dev/generated-marshaller-attribute branch from cd7f94c to 2daca71 Compare October 1, 2023 14:37
@Sergio0694
Copy link
Owner Author

Hey @Youssef1313, feel free to take a quick look if you feel like it! I've added a new code fixer in this one 😄

@Sergio0694 Sergio0694 force-pushed the dev/generated-marshaller-attribute branch from 2daca71 to bbf6607 Compare October 1, 2023 15:57
@Sergio0694 Sergio0694 force-pushed the dev/generated-marshaller-attribute branch from 1a15d34 to 462d724 Compare October 1, 2023 19:39
@Sergio0694 Sergio0694 force-pushed the dev/generated-marshaller-attribute branch from 145612f to 1029ad2 Compare October 2, 2023 01:22
@Sergio0694 Sergio0694 force-pushed the dev/generated-marshaller-attribute branch 2 times, most recently from 33c8dc6 to 312e49d Compare October 3, 2023 17:17
@Sergio0694 Sergio0694 force-pushed the dev/generated-marshaller-attribute branch from 312e49d to 1013cfb Compare October 3, 2023 17:22
@Sergio0694 Sergio0694 merged commit 57ecb78 into main Oct 3, 2023
48 checks passed
@Sergio0694 Sergio0694 deleted the dev/generated-marshaller-attribute branch October 3, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 💣 A change that is either binary or source breaking optimization 🚀 Performance improvement to existing APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants