Fixed broken ZeroR.

SergioFierens · Aug 1, 2009 · ca6a404 · ca6a404
1 parent 463c030
commit ca6a404
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/lib/ai4r/classifiers/zero_r.rb b/lib/ai4r/classifiers/zero_r.rb
@@ -30,13 +30,13 @@ class ZeroR < Classifier
       def build(data_set)
         data_set.check_not_empty
         @data_set = data_set
-        frequence = {}
+        frequencies = {}
         max_freq = 0
         @class_value = nil
         @data_set.data_items.each do |example|
           class_value = example.last
-          class_frequency = frequence[class_value]
-          class_frequency = (class_frequency) ? class_frequency+1 : 1
+          frequencies[class_value] = frequencies[class_value].nil? ? 1 : frequencies[class_value] + 1
+          class_frequency = frequencies[class_value]
           if max_freq < class_frequency
             max_freq = class_frequency
             @class_value = class_value

diff --git a/test/classifiers/zero_r_test.rb b/test/classifiers/zero_r_test.rb
@@ -6,15 +6,16 @@ class ZeroRTest < Test::Unit::TestCase
 
   include Ai4r::Classifiers
   include Ai4r::Data
-
-  @@data_examples = [   ['New York',  '<30',      'M', 'Y'],
-                ['Chicago',     '<30',      'M', 'Y'],
-                ['New York',  '<30',      'M', 'Y'],
-                ['New York',  '[30-50)',  'F', 'N'],
-                ['Chicago',     '[30-50)',  'F', 'Y'],
-                ['New York',  '[30-50)',  'F', 'N'],
-                ['Chicago',     '[50-80]', 'M', 'N'],
-              ]
+
+  @@data_examples = [
+          ['New York',  '[30-50)',  'F', 'N'],
+          ['New York',  '<30',      'M', 'Y'],
+          ['Chicago',     '<30',      'M', 'Y'],
+          ['New York',  '<30',      'M', 'Y'],
+          ['Chicago',     '[30-50)',  'F', 'Y'],
+          ['New York',  '[30-50)',  'F', 'N'],
+          ['Chicago',     '[50-80]', 'M', 'N'],
+  ]
 
   @@data_labels = [ 'city', 'age_range', 'gender', 'marketing_target'  ]