fix dynamic joystick to follow correctly #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Jun 23, 2023
Comment on lines
+60
to
+65
| let to_knob = knob.current_pos - knob.start_pos; | ||
| let distance_to_knob = to_knob.length(); | ||
| if distance_to_knob > half.x { | ||
| let excess_distance = distance_to_knob - half.x; | ||
| knob.start_pos += to_knob.normalize() * excess_distance; | ||
| } |
There was a problem hiding this comment.
it's becoming "a lot" of code duplicated so maybe creating a function could help.
There was a problem hiding this comment.
I think it's a great idea, I was thinking of doing something similar, do you think you can do it in another PR, as soon as I accept this one?
|
You're right, I hadn't noticed the problem with the cargo.lock, let me see it, I'll see about the toolchain as you're right |
|
LGTM! Thank you very much for your collaboration, your comments will be taken into account and I will release some commits in a moment ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small fix to the dynamic virtual joystick, I'm moving the start_pos following the size of the interaction zone. relying on the x of the interaction zone might not be what we want, because it would be difficult to support rectangular areas.
I guess a cleaner way would be to add a property to add a follow_distance, and check on that, Dynamic could be removed in favor of that property, where a fixed or a floating joystick could follow ?
Also nitpicks: