Update 1.0.10 #42
Update 1.0.10 #42
Conversation
| } | ||
| } | ||
|
|
||
| if ($entity instanceof Player and $entity->getGamemode() === GameMode::SPECTATOR){ |
There was a problem hiding this comment.
That will return error, pmmp uses in gamemode of the dynamic dummy functions. It should be GameMode::SPECTATOR()
There was a problem hiding this comment.
i don't think this will produce an error, because pmmp does the same thing
https://github.com/pmmp/PocketMine-MP/blob/fb9a74e8799c71ed8292cfa53abe7a4c9204629d/src/player/Player.php#L1199
There was a problem hiding this comment.
i don't think this will produce an error, because pmmp does the same thing https://github.com/pmmp/PocketMine-MP/blob/fb9a74e8799c71ed8292cfa53abe7a4c9204629d/src/player/Player.php#L1199
In that case, it will be removed soon... once they get rid of that.
| @@ -284,7 +284,9 @@ public function hideBossBar(): void { | |||
| } | |||
|
|
|||
| public function sendDataPacket(ClientboundPacket $packet): void { | |||
| $this->player->getNetworkSession()->sendDataPacket($packet); | |||
| if(Server::getInstance()->getPlayerExact($this->player->getName()) !== null and Server::getInstance()->getPlayerExact($this->player->getName())->getNetworkSession() !== null){ | |||
There was a problem hiding this comment.
Please change this to
| if(Server::getInstance()->getPlayerExact($this->player->getName()) !== null and Server::getInstance()->getPlayerExact($this->player->getName())->getNetworkSession() !== null){ | |
| if ($this->player->isConnected() && $this->player->spawned) { |
|
Also, use |
|
I won't merge this because everything will be added on a new big update (2.0.0), you can check it out on the branches |
👍👍 |
|
I am closing this pull because the next update is coming and hopefully this will be fixed in the next update. |
Fix spectator bug #40
Adedd Bossbar Color in Config #14