Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters for field templates #136

Open
Serhioromano opened this issue Sep 3, 2019 · 9 comments
Open

Parameters for field templates #136

Serhioromano opened this issue Sep 3, 2019 · 9 comments

Comments

@Serhioromano
Copy link
Owner

A lot of parameters in the field are related to how it looks. A good example is the gallery field. In order to proceed with making Cobalt looks simplify, I want to move all rendering specific parameres to field templates.

How it will work.

When you select a template, ther there is a corresponding XML file, additional parameters will appear in the list. No modal dialogs.

@kiranetph
Copy link
Collaborator

It would be good to have field template parameter.
Before we did not have this feature so everything needed to be hard coded.

@kiranetph
Copy link
Collaborator

additional parameters will appear in the list. No modal dialogs.

maybe they can appear "on demand". It means only if the user clicks a "reveal" icon. Otherwise too many parameter will be visible again, since every field has 3 field templates available
I'm thinking of something like this:

image

@kiranetph
Copy link
Collaborator

Addition:
In line with the template editing inside Cobalt 9, you should be able to edit the templates direct from the field parameter page.

@Serhioromano
Copy link
Owner Author

It is gonna be a modal window at the end. Why? Because when you load it to the right column list it shifts and you lose control. You cannot see what was added and where. You need a few moments to study the list of parameters to understand wah was loaded.

As much as I wanted to avoid modal, I do not see other way around.

2019-09-04_13-37-41

@Serhioromano
Copy link
Owner Author

The main architecture is done. Now I am going through all fields and refactor their parameters. That will probably take me 2 days.

@kiranetph
Copy link
Collaborator

Organised parameter under the template would be much nicer than a modal window.

Can you not "hide" first the default parameter of the default templates and only show them when you click the carpet icon (see me screenshot).
When you click the icon, it will reveal the parameter direct under the individual template.
if you change the template, the parameter block below the individual template changes.

I will try to make an image of it.

@kiranetph
Copy link
Collaborator

image

@kiranetph kiranetph reopened this Sep 4, 2019
@kiranetph
Copy link
Collaborator

kiranetph commented Sep 4, 2019

the 3 caret icon work like a radio button. only 1 is open. when you open another one, the open one will close.
With this approach, only minimal parameters are shown.
by default all are closed.
when you change the template, the parameter will change

@Serhioromano
Copy link
Owner Author

Anyway, in some fields, there are a lot of parameters. They will grow page 2 scrolls full heigh just template parameters. It will be still complicated. I'll leave it as it is now and we will see what others think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants