ID3v2: Report bad or unsupported frame IDs #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
changed the title
uklotzde
force-pushed
the
id3v2-frame-id
branch
2 times, most recently
from
d0a3f99
to
837a75c
Compare
|
Thanks, I reverted the purely fmt changes. I don't think it looks too good, I'll have to configure rustfmt to cut that out. |
|
I had to update my (barely) used nightly toolchain just to fix the CI errors. This is inconvenient. |
Serial-ATA
added a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to reveal information about malformed/unsupported tags.
Those frames should be skipped when parsing in
Relaxedmode.Note: The
BadFrameIderror was used for different purposes, not only for parsing as the message suggests.