Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'Involved People List' Id3v2 frame #215

Merged
merged 12 commits into from
Jul 5, 2023
Merged

Support 'Involved People List' Id3v2 frame #215

merged 12 commits into from
Jul 5, 2023

Conversation

FriederHannenheim
Copy link
Contributor

fixes #213

@uklotzde
Copy link
Contributor

uklotzde commented Jul 2, 2023

I suggest to add a round trip test (write -> read -> verify) an ID3v2 tag that contains a KeyValueFrame.

Serial-ATA
Serial-ATA requested changes Jul 2, 2023
View reviewed changes
src/id3/v2/frame/content.rs Outdated Show resolved Hide resolved
src/id3/v2/items/key_value_frame.rs Outdated Show resolved Hide resolved
src/id3/v2/items/key_value_frame.rs Outdated Show resolved Hide resolved
src/id3/v2/frame/mod.rs Outdated Show resolved Hide resolved
src/id3/v2/write/frame.rs Outdated Show resolved Hide resolved
FriederHannenheim and others added 7 commits July 2, 2023 20:36
@FriederHannenheim @Serial-ATA
Update src/id3/v2/write/frame.rs
a8255b2 
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
@FriederHannenheim @Serial-ATA
Update src/id3/v2/items/key_value_frame.rs
28c2191 
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
@FriederHannenheim @Serial-ATA
Update src/id3/v2/frame/mod.rs
b1ea4ea 
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
@FriederHannenheim @Serial-ATA
Update src/id3/v2/items/key_value_frame.rs
49208ab 
Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
@FriederHannenheim
Implement matching TMCL to KeyValueFrame and rename FrameValue
b95cdbd
@FriederHannenheim
Actually enable writing KeyValue frames
f1b55d2
@FriederHannenheim
Add test (not working yet)
aa3309f
@FriederHannenheim
Copy link
Contributor Author

FriederHannenheim commented Jul 2, 2023 •
edited

Thanks for your suggestions. I've implemented the requested changes and tried to create a test, however the test is failing. I don't know why. Could one of you maybe take a look?

Serial-ATA
Serial-ATA requested changes Jul 3, 2023
View reviewed changes
tests/files/mpeg.rs Outdated Show resolved Hide resolved
tests/files/mpeg.rs Outdated Show resolved Hide resolved
tests/files/mpeg.rs Outdated Show resolved Hide resolved
@FriederHannenheim
Copy link
Contributor Author

I've fixed the test

@Serial-ATA
Copy link
Owner

Looks good, thanks!

@Serial-ATA Serial-ATA merged commit f3841a3 into Serial-ATA:main Jul 5, 2023
12 checks passed
@Serial-ATA Serial-ATA mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde left review comments

@Serial-ATA Serial-ATA Serial-ATA requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ID3v2 IPLS/TPIL Involved People List is not read correctly
3 participants
@FriederHannenheim @uklotzde @Serial-ATA