ID3v2: Add simplified getters and setters for TXXX frames #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serial-ATA
force-pushed
the
id3v2-user-text
branch
from
2c0b4eb
to
48a0f87
Compare
|
@uklotzde Just making you aware of this, since you could probably use it. |
|
Yeah. You can easily get it wrong as we have seen ;) Working with the low-level ID3v2 frames is error prone due to the twofold addressing scheme. |
uklotzde
approved these changes
Jul 11, 2023
|
Realized I added a getter and setter with no way to remove them 😄. All good now. |
|
@Serial-ATA It is time for a 0.14.1 release to unlock all the fixes and extensions for dependent projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Id3v2Tag::{get, insert}_user_textto simplify the process of working with TXXX frames with their descriptions.