mp4: Skip unexpected or empty "data" ilst atoms #261
Conversation
| let content_len = (data_atom.len - 16) as usize; | ||
| if content_len == 0 { | ||
| // We won't add empty atoms | ||
| return Ok(None); |
There was a problem hiding this comment.
This early return was wrong. The comment states that multiple "data" atoms could occur, but the function aborts on the first empty atom.
|
Thanks! I'm not surprised atoms other than I'll get 0.16.1 out after looking into #260. |
|
@Serial-ATA How about releasing v0.16.1 after various fixes have been merged? |
|
I was going to release 0.16.1 after looking into that UTF-16 multi-value frame issue that was a part of #260. I just haven't been able to come up with a good solution yet. |
How do you extract the sample test data from the files? Creating a draft PR with a failing test could be a good starting point for anyone to pick this up. |
|
I just use a hex editor to either create tags by hand or just strip them out of files. It may be beneficial to make a simple binary to dump out all of the tags. That would save people from having to do that or email me their assets. Can't say when/if I'll get that done, though. |
Make use of
ParsingModeand ignore invalid/unexpectedilstatoms that could safely be ignored.I found a few affected files that are accepted by other MP4 parsers.
PS: It would be cool to include this in a v0.16.1 release soon.