Strip trailing null characters from decoded text #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
force-pushed
the
decode-text-trim-end-nulls
branch
from
2e8bc3f
to
46c0b22
Compare
uklotzde
force-pushed
the
decode-text-trim-end-nulls
branch
from
46c0b22
to
22e39de
Compare
Serial-ATA
reviewed
Oct 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix most issues when decoding text with trailing null characters.
Optionally, you could pass
ParsingModeto the text decode functions and only apply the trimming if non-strict parsing is requested.