Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP4 property fixups #298

Merged
merged 5 commits into from
Dec 5, 2023
Merged

MP4 property fixups #298

merged 5 commits into from
Dec 5, 2023

Conversation

Serial-ATA
Copy link
Owner

  • We used to not read the dfLa atom containing FLAC stream information, due to the wrong FOURCC being checked
  • Duration millisecond counts would sometimes be off by one. We now round, which should be done in other places.

@Serial-ATA
Properties: Remove old comment about FFmpeg reported bitrate
5ff9c5a 
Turns out our value of `280` is correct and matches FFmpeg.
@Serial-ATA
MP4: Fix FLAC atom FOURCC
54555c9 
The correct FOURCC is `dfLa`, so this would always be missed and properties would be incomplete.
@Serial-ATA
MP4: Round duration millis
9cb029d 
Fixes cases of us being off by one
@Serial-ATA
MP4: Use let else to prevent nesting
5371d41
@Serial-ATA
changelog: Update with MP4 changes
ddb8568
@Serial-ATA Serial-ATA merged commit 90ec1e2 into main Dec 5, 2023
12 checks passed
@Serial-ATA Serial-ATA deleted the mp4-fixes branch December 5, 2023 19:32
@Serial-ATA Serial-ATA added this to the 0.18.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Serial-ATA