Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemKey: Distinguish between Bpm and IntegerBpm #335

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

uklotzde
Copy link
Contributor

Fixes #334.

@Serial-ATA
Copy link
Owner

I believe "BPM" in Vorbis Comments and APE is also expected to be an integer value. At least that's how Picard uses it.

@uklotzde
Copy link
Contributor Author

I believe "BPM" in Vorbis Comments and APE is also expected to be an integer value. At least that's how Picard uses it.

I am only aware of ID3v2 and MP4 which impose these restriction. MP4 by atom type and ID3v2 by standard definition.

@uklotzde
Copy link
Contributor Author

Client still need to handle case that the integer field contains an arbitrary string, e.g. a decimal number.

@Serial-ATA
Copy link
Owner

Yeah, better to play it safe here.

This is marked draft, was there anything else planned for it?

@uklotzde uklotzde marked this pull request as ready for review January 11, 2024 22:03
@uklotzde
Copy link
Contributor Author

Yeah, better to play it safe here.

This is marked draft, was there anything else planned for it?

I first wanted to publish this for discussion. If you agree we could merge it.

@Serial-ATA
Copy link
Owner

Yep, these changes are good. Thanks!

@Serial-ATA Serial-ATA merged commit ac20868 into Serial-ATA:main Jan 11, 2024
12 checks passed
@Serial-ATA Serial-ATA added this to the 0.18.0 milestone Jan 12, 2024
@uklotzde uklotzde deleted the integer-bpm branch January 14, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add another ItemKey variant for float BPM values
2 participants